Code Monkey home page Code Monkey logo

magicsim's People

Contributors

chadlevy avatar phroph avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

magicsim's Issues

Advanced options are not showing

I currently am running Windows 7 SP1. Whenever I open the advanced tab for magicsim, nothing shows up. Cannot resize the window either.

error

v1.10.5 causes crashing.

Unsure on Event log locations to provide anything, but since v1.10.5 of SimC, MagicSim will crash on 'Generating Profile'.

Let me know what to provide info wise, but this was reproducible on several setups.

Reorigination array problem

I was trying to sim a shoulder item "Mantle of Contained Corruption" which has Archive of the Titans versus Sandspinner Mantle which does not have an Uldir trait. The former should sim higher as I have 5 stacks of the uldir buff. MagicSim seems to be ignoring the Reorigination array buff (375 haste). I also tried siming the Uldir piece with the SimC addon text manually edited to "stacks=0" to see if anything changed versus "stacks=5" and no difference.

If I'm doing something wrong, let me know, but it seems bugged to me.

Add Wdps to weights

Would be nice if Weapon Dps could be added to stat weight simming for non-priest users.

Missing Update for Essences / 8.2 Content / EP

Crashes with Error Message:

Errror running simc:
Error: Unknown option 'azerite_essences' with value '27:1/300573'.

Following a 2nd Error:
Failed to generate profile. Please check your input and try again.

"Failed to Generate Profile" error from SimulationCraft addon 1.10.5 input

The simc string generated by the SimulationCraft v1.10.5 addon causes a "Failed to Generate Profile" error in Magicism.

This appears to be caused by a comment in the second line of the simc output:

# SimC Addon 1.10.5
# 8.0 Note: reforge= is being used as a hacky way to capture item context. This will be changed in 8.1

priest="Muricas"
level=120
race=undead
region=us
server=tichondrius
role=spell
professions=tailoring=122/engineering=107
talents=3121322
spec=shadow

head=,id=163426,bonus_id=5125/1532/5136,reforge=28,azerite_powers=405/31
neck=,id=158075,bonus_id=4933/4936/4929/1502,reforge=11,azerite_level=16
shoulder=,id=157939,bonus_id=1517/4785,reforge=25,azerite_powers=482
back=,id=158159,enchant_id=6087,gem_id=154127,bonus_id=4803/4802/1522/4785,reforge=27
chest=,id=158301,bonus_id=4819/1512/4786,reforge=23,azerite_powers=505
shirt=,id=52019
tabard=,id=69210
wrist=,id=157877,gem_id=154127,bonus_id=4803/4802/1547/4784,reforge=27
hands=,id=157872,bonus_id=4803/1517/4785,reforge=26
waist=,id=159226,bonus_id=4778/42/1497/4785,reforge=2
legs=,id=159269,bonus_id=4778/1502/4781,reforge=2
feet=,id=158351,bonus_id=4779/1512/4786,reforge=23
finger1=,id=160985,enchant_id=5939,bonus_id=4803/1517/4785,reforge=26
finger2=,id=158366,enchant_id=5939,bonus_id=4777/1482/4785,reforge=1
trinket1=,id=158154,bonus_id=4803/1527/4783,reforge=26
trinket2=,id=159610,bonus_id=4779/41/1512/4786,reforge=23
main_hand=,id=159652,enchant_id=5963,bonus_id=4779/1512/4786,reforge=23
off_hand=,id=159668,bonus_id=4779/1512/4786,reforge=23

Suggested fix:

The regex for finding the player's name matches the first occurence of string=. Since that first occurence is in a comment, the whole thing falls over.

I suggest instead matching {classname}=:

SimcPreloaderData.cs, line 74:

Regex nameRegex = new Regex("(warrior|paladin|hunter|rogue|priest|death knight|shaman|mage|warlock|monk|druid|demon hunter)+=\"?([^\r\n\"]+)\"?");
String name = nameRegex.Match(simcString).Groups[2].Value;

Attached simc appears to consistently crash magicsim during the second sim.

Version: 2.0.1.1

Steps:

  1. Run magicsim.exe.
  2. Click 'From /simc'.
  3. Paste the simc data below.
  4. Click Continue.
  5. Click Add.
  6. Click Simulate.

Behavior: Crashes during simulation 2/10. Observed three times.

Let me know if I can provide more info.


# SimC Addon 1.9.1

hunter="Ape"
level=110
race=troll
region=us
server=mugthol
role=attack
professions=alchemy=793/herbalism=754
talents=3321231
spec=survival
artifact=34:0:0:0:0:1370:1:1338:1:1638:1:1083:1:1082:1:1081:1:1080:1:1068:1:1070:4:1071:4:1072:4:1079:1:1078:4:1077:4:1525:4:1526:1:1527:1:1528:24:1076:4:1075:4:1084:1:1074:4:1073:4
crucible=1739:1774:1073/1739:1778:1073/1739:1779:1073

head=,id=137064,bonus_id=1811/3630
neck=,id=151965,enchant_id=5437,bonus_id=3611/1502/3337
shoulder=,id=152371,enchant_id=5929,bonus_id=3614/1472/3528
back=,id=151937,enchant_id=5435,bonus_id=3611/1487/3528
chest=,id=151995,bonus_id=3611/1492/3336
wrist=,id=137101,bonus_id=3529/1811/3630
hands=,id=152132,bonus_id=3611/1492/3336
waist=,id=152683,gem_id=151583,bonus_id=3611/1808/1502/3337
legs=,id=152134,bonus_id=3611/1487/3528
feet=,id=134166,bonus_id=3536/1622/3337
finger1=,id=152284,enchant_id=5428,gem_id=151583,bonus_id=3613/1808/1487/3337
finger2=,id=149667,enchant_id=5428,gem_id=151583,bonus_id=3573/1808/1572/3528
trinket1=,id=151964,bonus_id=3613/1467/3336
trinket2=,id=141482,bonus_id=3466/1487/3337
main_hand=,id=128808,gem_id=152058/137408/151296,bonus_id=728,relic_id=3611:1487:3528/3536:1592:3528/3573:1562:3528

### Gear from Bags
#
# Helm of the Vigilant Eye (930)
# head=,id=152369,bonus_id=3614/1472/3528
#
# Collar of Null-Flame (945)
# neck=,id=151973,bonus_id=3611/1487/3528
#
# Prydaz, Xavaric's Magnum Opus (1000)
# neck=,id=132444,enchant_id=5437,gem_id=151583,bonus_id=1811/3630
#
# Serpentstalker Drape (920)
# back=,id=152131,bonus_id=3613/1462/3336
#
# Butcher's Bone Apron (1000)
# chest=,id=144361,bonus_id=3459/3630
#
# Fleet Commander's Hauberk (945)
# chest=,id=151994,bonus_id=3611/1487/3528
#
# Serpentstalker Tunic (945)
# chest=,id=152130,bonus_id=3611/1487/3528
#
# Nether Mindsnappers (905)
# hands=,id=134467,bonus_id=3418/1557/3337
#
# Waistguard of Devilish Deeds (930)
# waist=,id=152372,bonus_id=3614/1472/3528
#
# Ring of Braided Stems (895)
# finger1=,id=140896,enchant_id=5428,bonus_id=3514/1492/3337
#
# Kil'jaeden's Burning Wish (1000)
# trinket1=,id=144259,bonus_id=3459/3630
#
# Eye of Command (915)
# trinket1=,id=142167,bonus_id=3573/1527/3336
#

Closes on it's own

I start the application and get the inital options screen (Quick Sim, Armory etc). Then when on the next screen as soon as I click anywhere in the screen the app closes. Tried it several times and closes on me everytime.

exe file

Thank you for your hard work in creating this program. I am excited to use it, but when I download either the zip or the Win64 and open it, there isn't a nw.exe file to click per your instructions:
'-Click nw.exe'

What am I doing wrong? I have disabled my antivirus as was suggested to me from staff on the How To Priest Discord.

T3 Crucible traits causing error

When i import my Balance Druid via SimC string it leaves the first two t3 traits as 'none', if I manually assign them to their appropriate relic they sim refuses to be run ("Sims failed to be ran. Try again"). If i on the other hand leave them as 'none' the sim will run. The trait i am changing to is in both relics "Dark side of the moon".

How to reproduce:

  1. From /simc
  2. Pasting string (included below).
  3. Change potion from unbending to prolonged power, change first and second t3 trait from "none" to "Dark Side of the Moon"
  4. Add
  5. Simulate. (all sim parameters are left as default)

I've tested changing the two relic slots to some other trait than the one i actually have and it seems like that will make the sim run.

PC spec:
i7-7700k
Win 10
Radeon RX 480
16gb RAM

SimC import string:
`# SimC Addon 1.9.1

druid="Kletmåne"
level=110
race=highmountaintauren
region=eu
server=shattered_hand
role=spell
professions=herbalism=794/mining=127
talents=3322132
spec=balance
artifact=59:0:0:0:0:1501:4:1502:1:1503:1:1504:25:1364:1:1294:1:1632:1:1034:4:1035:4:1036:4:1037:4:1038:4:1039:4:1040:4:1041:4:1042:4:1043:1:1044:1:1045:1:1046:1:1047:1:1048:1:1049:1
crucible=1739:1777:1036/1739:1783:1036/1739:1780:1039

head=,id=152681,bonus_id=3612/1527/3337
neck=,id=151966,enchant_id=5890,bonus_id=3611/1487/3528
shoulder=,id=152129,enchant_id=5883,bonus_id=3611/1492/3336
back=,id=151800,enchant_id=5436,bonus_id=1811/3630
chest=,id=152124,gem_id=151584,bonus_id=3611/1808/1487/3528
shirt=,id=52019
wrist=,id=137092,bonus_id=1811/3630
hands=,id=152126,bonus_id=3611/40/1487/3528
waist=,id=151991,bonus_id=3610/1507/3337
legs=,id=152128,gem_id=151584,bonus_id=3611/1808/1492/3336
feet=,id=151981,bonus_id=3611/1502/3337
finger1=,id=137532,bonus_id=3536/1612/3337
finger2=,id=133634,enchant_id=5429,bonus_id=3536/1612/3337
trinket1=,id=137419,bonus_id=3418/1602/3337
trinket2=,id=151955,bonus_id=3611/1487/3528
main_hand=,id=128858,gem_id=155846/142309/144463,bonus_id=722,relic_id=3611:1497:3528/3536:1572:3337/3536:1592:3528

Gear from Bags

.
.
.
`

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.