fix: consider `l10n.yaml`'s `output-class` parameter when generating `PhraseLocalizations` class about flutter_sdk_example HOT 3 CLOSED

Hi @mugbug, thanks for sharing a workaround 🎉 With the latest release 2.4.0 output-class is now also supported directly by the SDK

from flutter_sdk_example.

Btw I was able to solve this by adding a script after the PhraseLocalizations class was generated. Here it is in case anyone needs it:

#!/bin/bash

## This script is used to replace the value of 'output-class' field in the l10n.yaml file
##
## Note: this script should be called only through the `melos exec` command
## https://melos.invertase.dev/environment-variables#melos_package_path

package_path=$MELOS_PACKAGE_PATH

# Read the value of 'output-class' field from the l10n.yaml file
output_class=$(awk '/output-class/ {print $2}' $package_path/l10n.yaml)

# Replace occurrences of 'AppLocalizations' with the value of 'output-class' in the Dart file
sed -i '' "s/AppLocalizations/$output_class/g" $package_path/lib/src/l10n/generated/phrase_localizations.dart

echo "Replaced 'AppLocalizations' to '${output_class}'"

phrase_class="Phrase$output_class"

# Replace occurrences of 'PhraseLocalizations' with the value of 'Phrase + output-class' in the Dart file
sed -i '' "s/PhraseLocalizations/$phrase_class/g" $package_path/lib/src/l10n/generated/phrase_localizations.dart

echo "Replaced 'PhraseLocalizations' to '${phrase_class}'"

In my case I use melos to manage the packages, but it can be used with other tools just by changing the package_path=$MELOS_PACKAGE_PATH to something like package_path=$1 and get the package path as a parameter when calling the script.

from flutter_sdk_example.

Hi @mugbug, I agree that it would be really useful to support setups like these for larger applications. When pulling the translations from Phrase how do you currently split it into multiple files for each package (ignoring the Phrase Flutter SDK for now)? Do you use tags or multiple projects?

Supporting this use case likely will require some larger changes in the architecture of over-the-air translations though. I'm creating a feature request for this to take a closer look at this

from flutter_sdk_example.