Comments (5)
lookyman
commented on June 16, 2024
1
I would, thanks. Also, we don't need to worry about older versions.
from phpstan-symfony.
nicwortel
commented on June 16, 2024
@lookyman would you accept a PR that reverses the logic so services are considered private by default?
How would you like to handle old Symfony versions?
That will result in false positives for Symfony versions < 3.4, but those versions are no longer supported by Symfony itself. Alternatively, the XmlServiceMapFactory would have to determine the Symfony version and switch it's logic based on that, but I'm not sure if that's even possible...
from phpstan-symfony.
jeroennoten
commented on June 16, 2024
I created #211 to resolve this.
from phpstan-symfony.
ondrejmirtes
commented on June 16, 2024
Fixed, merged, and released :)
from phpstan-symfony.
github-actions
commented on June 16, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from phpstan-symfony.
Related Issues (20)
- [Feature request] Check if certain option is set on each form HOT 4
- Call to an undefined method Symfony\Component\Validator\ConstraintViolationListInterface::__toString() HOT 3
- checkUninitializedProperties does not consider @required HOT 7
- Stubs overruling actual interface ? HOT 2
- `Form` is not subtype of native type `FormInterface` HOT 2
- Missing array as an available return type for InputBag::get() HOT 2
- Detection of invalid route names (and perhaps even missing/invalid params)
- `Required` attribute should remove readonly properties errors HOT 8
- Template type TData on class Symfony\Component\Form\FormInterface is not covariant HOT 1
- The constant_hassers not working as constantHassers default of extension.neon always used
- Support Symfony Validator HOT 6
- Method MyVoter::supports() has parameter $attribute with no type specified HOT 5
- Narrow property types in validated objects HOT 2
- Take into account the dynamic Kernel class HOT 16
- Request::getContent() return value without asResource is not always a string HOT 2
- Form "has invalid type Symfony\Component\Form\TData" after patch upgrade
- [Feature Request] Enforce `ResetInterface` on non-read-only services HOT 2
- PHPstan does not find container helper functions used on packages php configs HOT 5
- Remove reporting of deprecated method calls in tests flagged as `@group legacy` HOT 4
- Rule Idea: UriSigner check result is used and not used as a void method HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpstan-symfony.