Support custom Symfony Validation Constraint about phpstan-symfony HOT 7 CLOSED

Pretty much every Symfony constraint does exactly that: https://github.com/symfony/symfony/blob/2bfcaeb31ff3b878734b0951851d25abf2b3321e/src/Symfony/Component/Validator/Constraints/NotNullValidator.php#L28. There should not be any magic involved with this: I could easily create a FooConstraint that returns YourValidator::class in its validatedBy method, and all of a sudden YourValidator::validate would run into a fatal error because it receives a constraint class it doesn't expect or understand. In this case, you want to make sure you're given the correct type instead of assuming some magic to do so.

I suggest closing this issue as there's nothing to fix: asserting against the constraint class is exactly what should be done.

from phpstan-symfony.

For now, just ignore the error in PHPStan's config. But I will look into what can be done about it. Haven't really worked with the validation component before, so it may take a while..

from phpstan-symfony.

Okay thanks 👍

from phpstan-symfony.

Also, maybe you could probably just add something like assert($constraint instanceof IsString); into the IsStringValidator::validate() method..

from phpstan-symfony.

Oh, I didn't know Symfony check for Constraint instance.
Well, I will do the same, thanks you guys!

from phpstan-symfony.

Thanks @alcaeus 👍

from phpstan-symfony.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from phpstan-symfony.