Comments (4)
The concern I'd have with that is mcrypt_compat being loaded twice. phpseclib used to have issues with it being included twice:
random_compat works similarly to mcrypt_compat:
https://github.com/paragonie/random_compat/blob/master/lib/random.php
Mind you, whereas mcrypt_compat just does one if
check before defining everything random_compat does if
checks for everything.
from mcrypt_compat.
Hello all, I want to add check in legacy app, something like:
if(extension_loaded('mcrypt') || $hasMcryptCompat) {
//use mcrypt functions
} else {
//do something else
}
I can also use function_exists()
ofc, but detecting mcrypt_compat would be better solution.
Anyway, maybe solution to both problems (how to detect mcrypt_compat, or not load it twice) would be to add something like
define('PHPSECLIB_MCRYPT_COMPAT', true)
to mcrypt_compat ?
This way mcrypt_compat can detect if it's already loaded, it can use extension_loaded('mcrypt')
and we can detect that we have it.
Just a suggestion, thx for great polyfill !!
from mcrypt_compat.
phpseclib does three different tests in different places:
if (!defined('MCRYPT_MODE_ECB')) {
...
if (!function_exists('phpseclib_mcrypt_list_algorithms')) {
...
if (!function_exists('mcrypt_list_algorithms')) {
The only one that PHPSECLIB_MCRYPT_COMPAT
would be a viable solution would be !function_exists('phpseclib_mcrypt_list_algorithms')
and idk that it's any better than `PHPSECLIB_MCRYPT_COMPAT?
For your own check you could do !function_exists('phpseclib_mcrypt_list_algorithms')
yourself?
from mcrypt_compat.
I agree with @terrafrost here, that you should anyway test the feature (function exists, constant exists), not implementation details (extension_loaded, polyfill loaded). however, the loaded twice is not a real concern, why extension_loaded should not be used.
from mcrypt_compat.
Related Issues (20)
- create_function deprecated in PHP 7.2 HOT 6
- Enhance project description HOT 1
- Serpent Support HOT 1
- stream_filter_append output is different than original mcrypt when writing HOT 4
- phpseclib_mcrypt_module_open CFB mapping missing from 1.0 branch HOT 2
- test-related questions, understand whether you need to change the test in the testMcryptGenericMode HOT 1
- Fatal Error in Version 1.07 HOT 2
- Module initialization failed... PHP7.2.1
- Buffer bug in filter function HOT 5
- RC2 max key size incompatibility
- Uncaught Error: Class 'phpseclib3\Crypt\Blowfish' not found in lib/mcryptcompat/mcrypt.php:307 HOT 2
- THANKYOU!!!!!! HOT 1
- php 8.1 compatibility issues HOT 4
- OFB mode - Uncaught TypeError: Argument 1 passed to mcrypt_enc_get_iv_size() must be an instance of phpseclib3\Crypt\Common\SymmetricKey, bool given HOT 9
- PHP 8.1 deprecation warnings HOT 4
- Thank you thank you thank you
- Php 8.1 deprecation warning HOT 4
- Dependency on phpseclib/phpseclib:dev-master? HOT 5
- Can we also have old PHP behavior? HOT 11
- Could be nice if we can install in windows with $ winget install HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mcrypt_compat.