Code Monkey home page Code Monkey logo

Comments (14)

hskrtich avatar hskrtich commented on May 5, 2024

I hope to be able to work on this some time this week.

from phpword.

ivanlanin avatar ivanlanin commented on May 5, 2024

Fortunately, all servers that I've been dealing with provide php_zip. But, I since the tag line of PHPWord is a pure PHP library for reading and writing Word files, I think it will be good if we can also use a pure PHP compression utility :)

from phpword.

hskrtich avatar hskrtich commented on May 5, 2024

Yea, all of our servers dont have php_zip, so I had to hack in an alternative. Its very nice to not have PHPWord dependent on php_zip.

from phpword.

ivanlanin avatar ivanlanin commented on May 5, 2024

I consider myself lucky, then :) By the way, I think we should put the php_zip requirement in the README.

from phpword.

Progi1984 avatar Progi1984 commented on May 5, 2024

@bskrtich If you want PHPExcel use PCLZip for ZipEngine (https://github.com/PHPOffice/PHPExcel/tree/develop/Classes/PHPExcel/Shared/PCLZip).

But the best part in PHPExcel is the opportunity of change the ZIP Engine :

from phpword.

ivanlanin avatar ivanlanin commented on May 5, 2024

I think PHPWord\Settings is also where we should put the setting for #103 :)

from phpword.

Progi1984 avatar Progi1984 commented on May 5, 2024

@ivanlanin Affirmative :)

from phpword.

hskrtich avatar hskrtich commented on May 5, 2024

FYI I started on this already and I hope to have it done tomorrow.

from phpword.

ivanlanin avatar ivanlanin commented on May 5, 2024

Wow. Cool! Please create some unit tests for that since we're very close to 100% code coverage :) Travis said we're 91.31% now (4687/5133).

from phpword.

hskrtich avatar hskrtich commented on May 5, 2024

Ok the main code is done. Does someone mind doing a sanity check on my code before I write the unit tests for this?

from phpword.

ivanlanin avatar ivanlanin commented on May 5, 2024

I'll check.

from phpword.

ivanlanin avatar ivanlanin commented on May 5, 2024

I've submitted a pull request. Please review.

from phpword.

ivanlanin avatar ivanlanin commented on May 5, 2024

Resolved by #140 and #185 merge.

from phpword.

 avatar commented on May 5, 2024

Yea, all of our servers dont have php_zip, so I had to hack in an alternative.

@bskrtich, how could it be so? Which OS and which PHP version do you use?

from phpword.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.