Universal.Arrays.MixedArrayKeyTypes should report on explicit keys, if implicit keys are the majority about phpcsextra HOT 2 CLOSED

@kkmuffme That is not what this sniff is about. This sniff flags arrays with items which result in a mix of numeric and string keys. The sniff has no opinion on what type of keys the array should have. It only demands that the key type of the array is consistent: either all numeric keys, whether implicitly/explicitly set, or all string keys.

An array like the below will, for instance, not be flagged by this sniff as all items will end up having an integer key:

$array = array(
    'a',
    2 => 'b',
    '3' => 'c',
    4 => 'd',
);

often the string key can be removed completely, instead of adding an explicit key for the majority of array elements.

That is a perfectly valid way to solve the error this sniff throws, but it is not for this sniff to have an opinion on whether that is the preferred way to solve the error.

This feature request seems to be more closely related to the MixedKeyedUnkeyedArray sniff which demands that all array items have either an explicit key or an implicit key, but flags arrays which have a mix of both.

from phpcsextra.

Closing for lack of response.

from phpcsextra.