Comments (3)
Any ideas about this?
If we make the field unique in the DB, we may have problems with users who already have duplicate anchors. And if a user tries to add a new duplicate error, you get an ugly php general error output.
If we try to test for uniqueness in the entity set_anchor() method, we can more gracefully prevent adding new unique anchors... But any anchor will throw an error since the set_anchor method is run during the import method when getting existing data from the database, so it would always be found to be already existing/not unique, even if it is unique..
from boardrules.
I think during migration the script can check if there are duplicate anchors. If they exsist, just rename them and add log entry.
from boardrules.
This PR will make sure nobody can make duplicate anchors.
#168
from boardrules.
Related Issues (20)
- Beta 2 release mistake HOT 2
- RC1 HOT 1
- Use lang vars when installing sample rule data HOT 2
- Change categories when editing a rule
- Update notifications system HOT 1
- Remove Reset button from editing rules pages
- Hide rule message when editing a category
- Delete last rule issues with AJAX HOT 8
- More functional test coverage
- SQL Error: Duplicate entry 'phpbb.boardrules.notification.type.boardrules' for key 'type' [1062]
- Add better info to the delete rule confirmation text
- All rules disappeared HOT 2
- Add dedicated template var to indicate we are on the rules page HOT 6
- Use sql_freeresult after sql queries HOT 9
- Require phing as a dependency for -dev HOT 1
- Allow non-unique anchors between languages
- MS SQL Does not allow updating identity columns
- Refactor rule.php entity
- Default Lang fallback
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from boardrules.