Comments (9)
@swiffer what I was thinking is to have a flag is a similar fashion to patchFiles which is a boolean enabling the segment patching feature
https://github.com/php-edifact/edifact/blob/master/src/EDI/Interpreter.php#L45
from edifact.
For usage in implementation, it's difficult to know if it's an array of arrays (multiple returns) or just an array for one result.
I was wondering why you haven't choose to make return in stdclass ?
from edifact.
I would check with is_array... The choice was done initially because it was easy enough to work with the array and to json_encode it :-)
from edifact.
@sabas - 6 years later I got hit by this as I was reading an EDIFACT with could have multiple DTM segments but is not having them all the time. As I'm interating over the array this fails when there is only one DTM segment. Would be great to always return an array of results for consistancy whenever maxrepeat is > 1
from edifact.
@swiffer wow 6 years time flies hahaha
I actually need some time to remember the issue, but I suspect it would need to tweak the doAddArray function
https://github.com/php-edifact/edifact/blob/master/src/EDI/Interpreter.php#L578
So to always make it an array, something like
if (isset($array[$jsonMessage['key']])) {
$array[$jsonMessage['key']] = [];
}
$array[$jsonMessage['key']][] = $jsonMessage['value'];
Would you try something like this? In case we could do some sort of flag to control this mode.
from edifact.
@sabas for now i'm using something like this:
if (!array_is_list($detail['SG6'][0]['date/time/period'])) {
$detail['SG6'][0]['date/time/period'] = [$detail['SG6'][0]['date/time/period']];
}
you mean having an option passed to:
new Interpreter(,...) ?
from edifact.
sounds good to me
from edifact.
@swiffer Hi Matthias, would you please send me (mail is in profile) an EDI sample so I can think about the solution?
Perhaps also highlighting what would be the desired structure... :)
Also offtopic, I updated the mappings and I wanted to alert you that now the names don't contain slashes (I found out xml doesn't want them in the name attribute) so date/time/period => dateOrtimeOrperiod
from edifact.
Ok, I made a new flag, if set true then if the maxrepeat is greater than 1 it makes an array also for a single segment
$interpreter->forceArrayWhenRepeatable(false);
from edifact.
Related Issues (20)
- Release 0.5.0 not available via Composer HOT 2
- Possibility to have IDs instead of name as output from Interpreter::prepare HOT 5
- CDR read HOT 4
- Problems reading RFF segment from EDI-File HOT 1
- Array to string conversion, if an epty array met. HOT 1
- X12 HOT 6
- Package ramsey/array_column is abandoned HOT 2
- Trouble understanding how to get the data we need HOT 5
- Segment is ambiguous HOT 1
- Elements with maxrepeat > 1 should be considered arrays when parsed as json HOT 6
- Reader doesn't return full multi-line texts HOT 4
- Multiple SG2 segments not allowed HOT 8
- Does IFTMIN:S:93A supported? HOT 5
- UTF8 characters handling in input edi file HOT 15
- How to create edi document with .edi extension for healthcare HOT 4
- readEdiSegmentDTM for SG12 HOT 5
- File has multiple messages HOT 6
- question marks are not parsed correctly HOT 5
- Fatal error on integer-value segments for Encoder HOT 2
- Reader cannot be init with a null param HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edifact.