`fully_qualified_strict_types` does not respect locally declared symbols when importing FQCNs about php-cs-fixer HOT 6 OPEN

It won't be easy, but it's not impossible. We need to scan current namespace (whole file or within {}) for symbols and use these names just like we use list of existing imports.

from php-cs-fixer.

3.44 is fine because importing symbols was enabled in @PhpCsFixer ruleset in 3.45, so previously it did not try to import symbols... As a workaround you can disable this by configuring fully_qualified_strict_types=true, or with explicit import_symbols=false option.

Naming conflict with symbols living in a processed file was not taken into consideration, unfortunately 😞.

from php-cs-fixer.

Naming conflict with symbols living in a processed file was not taken into consideration, unfortunately 😞.

you think it can, @Wirone ?

from php-cs-fixer.

Also this usecase is broken currently:

--RULESET--
{
    "@PhpCsFixer": true,
    "@PhpCsFixer:risky": true
}

--INPUT--
<?php

new MyCl();
new \MyExample\MyCl();

--WRONG-FIX--
<?php

use MyExample\MyCl;

new MyCl();
new MyCl();

from php-cs-fixer.

@mvorisek looks more like #7632 🤔. No, it's different.

from php-cs-fixer.

Here is how the fixer must be fixed:

1. there are declarations like class X
2. there are references like class X extends Y or new X

in both cases, even in the 2nd case, the used short symbols must imply "same namespace imports if not already imported", thus contribute to $uses before any fix is run.

from php-cs-fixer.