Infinite loop if I decode a abnormal arraybuffer about upng.js HOT 12 CLOSED

Hi, this function is only used for Encoding PNG, not for decoding. What kind of "abnormal" ArrayBuffer did you put into it?

from upng.js.

oh, I copy wrong line.

Abnormal arraybuffer obtained by FileReader API.

from upng.js.

How long is your ArrayBuffer? What makes it "abnormal" ? Can you send us your PNG file to [email protected] ?

from upng.js.

The image, that you sent us, is a JPG image. This library can work only with PNG images. You should use some different library for parsing JPG images.

from upng.js.

I pay no attention to its size. Looks very small. And log “unknow chunk type”.
You can download here https://github.com/Aqours/APNG-Codec/blob/master/test/elephant.png
Look like iOS cannot download apng.

from upng.js.

I tried to open your APNG with this version of UPNG.js and it works well.

Can you try to update your UPNG.js file? Are you sure you are sending an arraybuffer into decode(), not your FileReader or anything else?

from upng.js.

It works fine if using ArrayBuffer from 'correct' but not FileReader.
ArrayBuffer from FileReader maybe not suitable for UPNG.decode method, but it should not decode infinite loop, because sometimes we don't know whether the ArrayBuffer is suitable for UPNG.decode method or not.

from upng.js.

what do you mean by "correct"? whenever UPNG gets a valid PNG file, it should decode it in finite time.

from upng.js.

demo1 - http://git.hub.moe/laboratory/decode-apng-normal.html (open this link with modern browser)
this demo works fine.

demo2 - http://git.hub.moe/laboratory/decode-apng-abnormal.html
this demo does not work.
you will see some message on browser's console.

from upng.js.

In your picture, I see a message, that your PNG file was not found. This is not related to UPNG.js

The message from UPNG.js basically says, that you are not giving it a PNG file, but some other file (like PDF or EXE or something).

from upng.js.

I mean that unexpected arraybuffer should not cause UPNG.js blocking browser, because sometimes we don't kown whether the arraybuffer decoded by UPNG.js is excepted or not. (Inexistence png is just for demo)
Throw an error or other ways might be better solution.

from upng.js.

Ok, I added some basic PNG check. If the ArrayBuffer on the input is not a PNG file, it should throw an exception.

from upng.js.