Make the library more Pythonic about openphoto-python HOT 7 CLOSED

I'm all for it! I know that @jmathai was hoping to keep the various libraries fairly consistent. Jaisen, I think this would make the client much easier to use - can we start with Python and revisit the other libraries?

from openphoto-python.

Sorry, I'm still learning the GitHub flow.. consider this a duplicate of my pull request in issue #13!

from openphoto-python.

@walkah @sneakypete81 No opposition from me. Whatever makes the most sense for Python devs is > than my philosophical desire to keep the libraries consistent :)

from openphoto-python.

Cool. I'll review the pull request then when I get a chance. @jmathai maybe I'll have a look at bringing some of the other libraries in line - cake and eat it too ;-)

from openphoto-python.

@walkah Possible to leave them backwards compatible for a few versions?

from openphoto-python.

I would think that's a very good idea, yes.

from openphoto-python.

Makes sense to me. Most of my changes are additions rather than modifications to existing behaviour, but you can consider whether or not to include the following modifications to the get() and set() method behaviour:

1. Parameters are passed in as keywords rather than a single dictionary: get(endpoint, param1=value1, param2=value2) instead of get(endpoint, {"param1": value1, "param2": value2}).
2. Lists and boolean parameters are handled correctly. This doesn't affect compatibility, and seems like a good idea.
3. The HTTP response is (optionally) parsed to a dict. The old behaviour can still be requested by specifying "process_response=False". We could make this the default if you like - I chose to make the default "True" since a dict is more useful than a JSON string.
4. Error response codes (optionally) raise exceptions. As above.

from openphoto-python.