[Feature Request] Be able to transform a module into a Pub.Sub about phoenix_pubsub HOT 6 CLOSED

Why would you like to do this? What benefit does it offer over the existing:

  def start(_type, _args) do
    children = [
      MyRepo,
      {Phoenix.PubSub, name: MyPubSub},
      # ....
    ]
  end

from phoenix_pubsub.

@Gazler maybe it is a matter of docs, so help me here.

From my perspective, I get to put static configuration and be able to override it the environment much easier, as well as be explicit in terms of the intention that such module and name is used for Phoenix Pub.Sub, and be able to change the adapter per pub/sub.

defmodule MyPubSub do
  use Phoenix.PubSub,
    adapter: Phoenix.PubSub.PG2
end

defmodule AdminPubSub do
  use Phoenix.PubSub,
    adapter: Phoenix.PubSub.PG2
end

# config/prod.exs

config MyPubSub,
      adapter: Phoenix.PubSub.Redis

@chrismccord would appreciate some feedback before closing it thou, people will get to learn about the decision made 🙏🏻

from phoenix_pubsub.

We don't accept feature requests on the issue tracker. The module and config in this case only serves as indirection so the supervision tree is preferred. Thanks!

from phoenix_pubsub.

We don't accept feature requests on the issue tracker.

Where do we suppose to send feature requests? It would help in the future to figure out what we suppose to do.

from phoenix_pubsub.

We don't accept feature requests on the issue tracker.

Where do we suppose to send feature requests? It would help in the future to figure out what we suppose to do.

https://github.com/phoenixframework/phoenix/blob/master/CONTRIBUTING.md#feature-requests

from phoenix_pubsub.

@arpunk thank you so much, I will create a PR that helps to understand what to do when creating a new issue.

from phoenix_pubsub.