Code Monkey home page Code Monkey logo

Comments (5)

hukl avatar hukl commented on July 23, 2024

The reason was that COPY also copied the local _build folder which contained the esbuild executable which was of the type esbuild: Mach-O 64-bit executable arm64 and therefor didn't run in our linux docker image. Would've still been great to have a more descriptive error ;)

from esbuild.

cw789 avatar cw789 commented on July 23, 2024

It's difficult to get a descriptive error for this case.
If the wrong esbuild binary thought for a different OS architecture is present,
the call to esbuild will possibly just fail (or even work and then fail).

But I understand if one stumble across this problem it's difficult to find the cause.


The current esbuild implementation does not have any information for which OS architecture the present esbuild binary is for.

The only solution I could think of, we would need to save the esbuild binary with the OS architecture information attached.
_build/esbuild-linux-64

Then at runtime always check the target and call the binary with it.

@josevalim May I ask you for your opinion? Is it worth it to go this way?

from esbuild.

josevalim avatar josevalim commented on July 23, 2024

@cw789 I think saving it as esbuild-linux64 doesn't hurt and we already have the logic to compute the architecture anyway. Can you please send a PR? :)

from esbuild.

hukl avatar hukl commented on July 23, 2024

Oh I'm glad filing this was still useful :)

from esbuild.

cw789 avatar cw789 commented on July 23, 2024

Can you please send a PR? :)

Sure, I love to do so.

Oh I'm glad filing this was still useful :)

Of course it is. Thanks.
Give me some time and we both won't stumble again over this problem.

from esbuild.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.