Comments (4)
samreid
commented on August 16, 2024
In discussion, @jonathanolson said: "I should probably assert( bounds.isEmpty() || bounds.isFinite() )".
I changed the assertion like you recommended and it seems like it solves the problem. Specifically, I changed the assertion that bounds x is finite and not NaN to: must be empty or finite. After this change, I tested qunit and 2516/2516 test passed (in Win8Chrome), so I will push to master.
from scenery.
samreid
commented on August 16, 2024
Reassigned to @jonathanolson to verify my change set.
from scenery.
samreid
commented on August 16, 2024
Do we also need to retain the test for NaN in the bounds? Also, the former test that was replaced just checked the x value for NaN (see 93b822f)
from scenery.
jonathanolson
commented on August 16, 2024
isFinite( NaN ) is false, so this should work well. Changeset looks good.
from scenery.
Related Issues (20)
- Reduce potential of infinite loops with setLayoutOptions HOT 2
- KeyboardDragListener can drag even if Pointer is already attached HOT 1
- Address problems with KeyboardDragListener options HOT 1
- KeyboardDragListener end listener fired regardless of whether it is currently dragging HOT 1
- pdomOrder has a memory leak HOT 4
- KeyboardDragListener shouldn't use CallbackTimer for 'dragSpeed' implementation HOT 4
- Where should focus go when a button disappears? HOT 2
- VoiceOver does not voice changed shape in Scenery Demo HOT 2
- createGatedVisibleProperty should be a Class HOT 2
- KeyboardDragListener should be parametric
- Layout of RTL broken in Firefox 128 HOT 7
- Bug report for Firefox embedding mark regression HOT 2
- interruptSubtreeInput when a Node becomes invisible. HOT 5
- Remove redundant uses of `interruptSubtreeInput`. HOT 1
- Node with inputEnabled false blocks input events to Nodes behind it. HOT 1
- Bogus documentation for SpriteInstance.initialize HOT 2
- WebGL is broken on iPad HOT 2
- Scenery Doc live on github.io has broken header buttons HOT 3
- Path.shapeProperty and Image.imageProperty refactoring
- HighlightOverlay shapeProperty support?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scenery.