Comments (3)
That's a good point, I had assumed users of this addon added their own code to track page views (much like the snippet you have), but I missed the double page view issue.
I've merged your pull request and I've also added a mixin with your code above so that people can easily add tracking to route transitions. I added a small blurb to the README
from ember-cli-google-analytics.
I've published version 1.3.0 here and on npm with these changes
from ember-cli-google-analytics.
Great stuff, thanks @pgrippi
from ember-cli-google-analytics.
Related Issues (13)
- Allow analytics to be sent when running on localhost HOT 1
- Runtime error with Ember CLI 0.2.5 HOT 5
- Add configuration object to ga('send')? HOT 3
- Addon places javascript above CSS code
- Is there any way to enable/disable ganalytics at runtime? HOT 1
- Enhanced Link Attribution
- Content-Security-Policy Warnings HOT 3
- Handle sensitive URLs
- It is not working for me Ember v2.4.0, Ember-CLI v1.13.12
- Retiring this project in favor of @onehilltech/ember-cli-google-analytics
- Default config not set HOT 2
- Enable options to set multiple trackers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-cli-google-analytics.