Rather than closing all the file descriptors, set close on exec on them about ptyprocess HOT 3 OPEN

currently linux only solution: petesh@a4a0090
I'll see about other solutions

from ptyprocess.

The Python subprocess module also appears to close fds explicitly rather than setting CLOEXEC, although it happens in C code rather than Python. I'd want to hear from the maintainers of that whether there are any downsides to setting CLOEXEC before changing that.

from ptyprocess.

Because it happens in python, it still leaves the cleanup of objects prior to the exec; which has hidden swallowed OSError exceptions coming from instances of classes being torn down who have file.close() calls in their __del__ methods.

It's not really safe code. CLOEXEC is a somewhat better solution as your code path is trying to get to only there, and if it fails, you always exit.

from ptyprocess.