Since there already is a pure-Python impementation used for PyPy, why not also use it as a fallback for when the C implementation isn't available, e.g. if compilation fails?

See for example the setup.py file in the simplejson project, or a simplified version in my fuzzysearch library.

Relevant especially on Windows (though that could also be solved by supplying binary wheels) but also on macOS etc.

Related to issue #1.

Hi,

The tarball which you provide on PyPI does not ship with tests.py, yet setup.py still references this file. Would you be able to either add tests.py, or remove the reference in setup.py?

Thanks for considering,

appleorange1

c.f. this question. The pointers absolutely need to be volatile-qualified, otherwise the compiler can optimize the loop into just ~equivalent of memcmp

At first I was getting the "unable to find vcvarsall.bat" error, and after fixing that, I tried pip installing streql and got this error:

PS C:\Users\Lee> pip install streql
Downloading/unpacking streql
Downloading streql-3.0.2.tar.gz
Running setup.py (path:c:\users\lee\appdata\local\temp\pip_build_Lee\streql\setup.py) egg_info for package streql

Installing collected packages: streql
Running setup.py install for streql
building 'streql' extension
C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\cl.exe /c /nologo /Ox /MD /W3 /GS- /DNDEBUG -IC:\Python27
include -IC:\Python27\PC /Tcstreql.c /Fobuild\temp.win32-2.7\Release\streql.obj
streql.c
streql.c(7) : error C2143: syntax error : missing ';' before 'type'
streql.c(8) : error C2065: 'i' : undeclared identifier
streql.c(8) : error C2065: 'i' : undeclared identifier
streql.c(8) : warning C4018: '<' : signed/unsigned mismatch
streql.c(8) : error C2065: 'i' : undeclared identifier
streql.c(8) : error C2065: 'result' : undeclared identifier
streql.c(8) : error C2065: 'i' : undeclared identifier
streql.c(8) : error C2065: 'i' : undeclared identifier
streql.c(9) : error C2065: 'result' : undeclared identifier
streql.c(16) : error C2143: syntax error : missing ';' before 'type'
streql.c(19) : error C2065: 'equal' : undeclared identifier
streql.c(27) : error C2061: syntax error : identifier 'streql_methods'
streql.c(27) : error C2059: syntax error : ';'
streql.c(27) : error C3409: empty attribute block is not allowed
streql.c(27) : error C2513: '/global/ ' : no variable declared before '='
streql.c(51) : error C2065: 'streql_methods' : undeclared identifier
streql.c(51) : warning C4047: 'function' : 'PyMethodDef *' differs in levels of indirection from 'int'
streql.c(51) : warning C4024: 'Py_InitModule4' : different types for formal and actual parameter 2
error: command '"C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\cl.exe"' failed with exit status 2
Complete output from command C:\Python27\python.exe -c "import setuptools, tokenize;file='c:\users\lee\appdat
a\local\temp\pip_build_Lee\streql\setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('
\r\n', '\n'), file, 'exec'))" install --record c:\users\lee\appdata\local\temp\pip-h9hneu-record\install-record.txt
--single-version-externally-managed --compile:
running install

running build

running build_ext

building 'streql' extension

creating build

creating build\temp.win32-2.7

creating build\temp.win32-2.7\Release

C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\cl.exe /c /nologo /Ox /MD /W3 /GS- /DNDEBUG -IC:\Python27\incl
ude -IC:\Python27\PC /Tcstreql.c /Fobuild\temp.win32-2.7\Release\streql.obj

streql.c

streql.c(7) : error C2143: syntax error : missing ';' before 'type'

streql.c(8) : error C2065: 'i' : undeclared identifier

streql.c(8) : error C2065: 'i' : undeclared identifier

streql.c(8) : warning C4018: '<' : signed/unsigned mismatch

streql.c(8) : error C2065: 'i' : undeclared identifier

streql.c(8) : error C2065: 'result' : undeclared identifier

streql.c(8) : error C2065: 'i' : undeclared identifier

streql.c(8) : error C2065: 'i' : undeclared identifier

streql.c(9) : error C2065: 'result' : undeclared identifier

streql.c(16) : error C2143: syntax error : missing ';' before 'type'

streql.c(19) : error C2065: 'equal' : undeclared identifier

streql.c(27) : error C2061: syntax error : identifier 'streql_methods'

streql.c(27) : error C2059: syntax error : ';'

streql.c(27) : error C3409: empty attribute block is not allowed

streql.c(27) : error C2513: '/global/ ' : no variable declared before '='

streql.c(51) : error C2065: 'streql_methods' : undeclared identifier

streql.c(51) : warning C4047: 'function' : 'PyMethodDef *' differs in levels of indirection from 'int'

streql.c(51) : warning C4024: 'Py_InitModule4' : different types for formal and actual parameter 2

error: command '"C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\cl.exe"' failed with exit status 2

for (i = 0; i < xlen; i++) result |= x[i] ^ y[i];
https://github.com/PeterScott/streql/blob/master/streql.c#L8

The for depends on the length of the strings. How is this constant time? Or what do you refer to with constant-time?