Comments (13)
Fixed in 0.25.1. Thanks @smoelius
from strum.
Please do not yank!
Agreed. I didn't consider that the derive macros are a separate feature.
from strum.
Like Martin said, we can't really rollback, 0.25 already had 10,000 downloads so people have already updated, and this would break them.
Pinning to 0.24
is definitely the correct solution for affected users until a patch fix is released.
from strum.
The issue is resolved, even though strum
lists the required version of strum_macros
as 0.25.0
it will still pull in any subsequent patch releases, as this is all semver compatible.
If you're still having build issues you need to try to clean and update first. I was experiencing this FromRepr
issue in a few projects and simply running cargo update
prior to re-building has fixed it in all of them.
from strum.
I suggest to yank v0.25.0 until the issues with doc comments are resolved.
from strum.
Please do not yank!
These will lead to many broken projects which do not use this functionality.
Better fix it and release 0.25.1
from strum.
Please consider releasing the bugfix soon. Versions are cheap and not a scarce resource.
from strum.
I released it yesterday. You might need to run cargo update
to pick up the patch version if you pinned to 0.25.
from strum.
Still 0.25.0 on crates.io at this moment.
from strum.
The corresponding Git tags are also missing. I suggest to tag each release to ensure traceability.
from strum.
The main crate is still at 0.25.0 and pulls strum_macros 0.25.0. That doesn't fix the issue.
from strum.
There's 2 packages, strum and strum_macros; since this bug only affected codegen, only strum_macros needed a new version
from strum.
Thanks for the clarification. It is confusing that it suddenly works even though the main crate is still at 0.25.0. Beforehand I always needed to downgrade it manually from 0.25.0 to 0.24.1 after running cargo upgrade --incompatible
. If the Cargo.lock
file is not part of the repo you don't notice this change behind the scenes.
from strum.
Related Issues (20)
- EnumIter does not work for enums named 'Option'
- [Feature] Macro to Implement PartialEq<str> HOT 1
- strum::Display doesn't work with non-unit non-string variants
- `EnumString` should derive `From<&str>` instead of `TryFrom<&str>` when `#[strum(default)]` is present HOT 1
- to_string and serialize when used together causes unreachable code HOT 2
- `get_bool` and `get_int` in `EnumProperty` are undocumented and always return None
- AsRef<str> and default variants
- EnumDiscriminants: can't infer type HOT 3
- Getting the discriminant from an enum variant HOT 3
- Publish new release. HOT 4
- AsRefStr documentation incorrectly states 'static ref is returned HOT 2
- Publish Git tags HOT 2
- TryFrom<Repr> for enums using FromRepr? HOT 2
- Implement `Iterator` for EnumTable HOT 6
- Customize error message for FromStr
- Documentation for `VariantArray` and `VariantNames` say their `VARIANTS` constants are arrays, but they're actually slices HOT 2
- Support for const_into_str to Enable Static String Conversion in Const Context
- Accessing the EnumTable type through the enum HOT 1
- Error updating to 0.26 - trait bound `std::iter::FusedIterator` is not satisfied HOT 1
- Itertools 0.13.0 and strum derive macro EnumIter break if both are used at the same time HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from strum.