Comments (12)
@peter-evans your fix works well at my GitHub action! Thank you, I really appreciate your help 🙏
from create-pull-request.
Hotfixed v1
. Please let me know if the issue is fixed for you.
I recommend updating to v2
. There is a brief guide to the changes here.
from create-pull-request.
I forked your repo and tested it. Works ok for me. Please could you retry?
https://github.com/peter-evans/DAppNodePackage-nethermind/commit/1c8b752dbbc2eef6f5e9495a465e4cb167bed63b/checks?check_suite_id=405974391
from create-pull-request.
Looks like it does work now :o A little bit strange, but seems like it's back on track now. Thank you!
from create-pull-request.
@peter-evans thank you for the fix! I will try and let you know 🙏
from create-pull-request.
Thanks for this report. I've just checked and it affects v2
as well.
I've not touched any code recently so it must be some dependency that is causing the problem. Trying to figure this out...
from create-pull-request.
Figured out the problem. They removed Python v3.8.0 from the GitHub Actions tool cache. I'm not sure why yet, but it doesn't exist anymore. I've hotfixed v2
by updating to Python v3.8.1.
from create-pull-request.
I am experiencing same issue, tried with v2.1.1 version, but the problem persists.
from create-pull-request.
@matilote All my tests are working fine on v2
now. Could you share your workflow so I can investigate further.
from create-pull-request.
@peter-evans sure, I've just changed cpr to v2, same result.
name: Update Manifest file
on:
repository_dispatch:
types: dappnode_update
jobs:
dappnode-update:
name: Update Manifest file
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Cloning nethermind repo and fetching latest tag
run: |
git clone https://github.com/NethermindEth/nethermind.git
cd nethermind/ && git describe --tags > git-tag
- name: Updating package and Nethermind versions
run: |
GIT_TAG="$(tail nethermind/git-tag)"
VER="$(sed -n '3p' dappnode_package.json)"
VERSION=${VER:14:-2}
VERSION_UPDATED="$(./semver-update.sh patch $VERSION)"
sed -i "3s/.*/ \"version\": \"${VERSION_UPDATED}\",/" dappnode_package.json
sed -i "4s/.*/ \"upstreamVersion\": \"v${GIT_TAG}\",/" dappnode_package.json
sed -i "5s/.*/ image: 'nethermind.public.dappnode.eth:${VERSION_UPDATED}'/" docker-compose.yml
rm -rf nethermind/
- name: Create Pull Request
uses: peter-evans/create-pull-request@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
commit-message: Update manifest
body: |
Manifest file has been updated.
- Files included - dappnode_package.json
- Auto-generated by [create-pull-request][1]
[1]: https://github.com/peter-evans/create-pull-request
title: 'Updating Manifest file'
labels: manifest
author-name: github-actions[bot]
author-email: 41898282+github-actions[bot]@users.noreply.github.com
committer-name: GitHub
committer-email: [email protected]
branch: manifest-update
branch-suffix: short-commit-hash
base: master
- name: Checking Outputs
run: |
echo "Pull Request Number - ${{ env.PULL_REQUEST_NUMBER }}"
from create-pull-request.
@matilote I see that your workflow is triggered on repository_dispatch
. That event will always use workflows in the default (usually master
) branch. Is the workflow you shared above committed to the default branch?
The v2
version of the action should now be fixed, so I think you might be triggering a workflow that is still using an old version of the action.
from create-pull-request.
The above workflow is merged into master, you can see here that I am using v2 https://github.com/NethermindEth/DAppNodePackage-nethermind/commit/1c8b752dbbc2eef6f5e9495a465e4cb167bed63b/checks?check_suite_id=405868619
from create-pull-request.
Related Issues (20)
- This works great
- When the workflow is triggered with `base` and `branch`, the PR is not created HOT 1
- Syntax error line 17 HOT 2
- remote missing HOT 2
- How to always have open PR from dev to prod HOT 1
- Autosync PR out of date HOT 2
- Automatically delete body-path HOT 1
- Not opening PR's HOT 2
- Support creation of one PR per file HOT 2
- Overcoming github's limitations on triggering CI HOT 1
- PR is not updated even there are changes after new incoming changes on master HOT 4
- Run bot
- DeeNuff
- Attempting creation of pull request Error: Not Found HOT 10
- Resource not accessible by integration HOT 6
- It is not possible to create two continuous pull requests HOT 2
- Cannot create a Pull Request when it flags conflicts HOT 9
- Unexpected v7 error `fatal: ambiguous argument` on `diff --stat` HOT 5
- [Feature Request]: Allow commit author to be optional HOT 1
- Commit is not recreated if author changes HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-pull-request.