Code Monkey home page Code Monkey logo

Comments (5)

mimecuvalo avatar mimecuvalo commented on September 21, 2024 1

Thanks for investigating! And thanks for the great package you've written - super useful ^_^

from create-pull-request.

peter-evans avatar peter-evans commented on September 21, 2024 1

@mimecuvalo This should now be fixed in the latest release.

My test case for this creates an LFS tracked file and it is successfully pushed to a branch.

      - name: Create LFS tracked file
        run: |
          git lfs track "*.dat"
          date +%s > large_file.dat
      - name: Create Pull Request
        uses: peter-evans/create-pull-request@v2
        with:
          token: ${{ secrets.GITHUB_TOKEN }}

from create-pull-request.

peter-evans avatar peter-evans commented on September 21, 2024

@mimecuvalo Thank you for raising this issue. This is interesting because 289fda9 was an attempt to copy how the official actions/checkout action handles authentication.

I've found Git LFS tests that strongly suggest it does work with extraheader so it looks fixable. I will try to reproduce this problem in a workflow.

It would be helpful if you could provide a more complete workflow to help me reproduce this.

from create-pull-request.

peter-evans avatar peter-evans commented on September 21, 2024

I've discovered that this is a possible bug with Git LFS itself.
Created this issue to report my findings: git-lfs/git-lfs#4031

For now, please version pin to v2.4.1.

      - name: Create Pull Request
        uses: peter-evans/[email protected]
        with:
          token: ${{ secrets.GITHUB_TOKEN }}

from create-pull-request.

mimecuvalo avatar mimecuvalo commented on September 21, 2024

Thanks for fixing it so fast! I was following the discussion on the other bug - was great to see the git-lfs team being so responsive, too :)

from create-pull-request.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.