Comments (8)
Yes, because 0.8.0 is equal to 0.008000 in numeric.
On Mon, Aug 3, 2015, 9:57 PM Mike Schilli [email protected] wrote:
I know that comparing versions can be tricky, but is it really reasonable
to reject version 0.8.0 when someone requires 0.6 and above?use CPAN::Meta::Requirements;
my $build_requires = CPAN::Meta::Requirements->new;
$build_requires->add_minimum('Thrift' => '0.6');
if( $build_requires->accepts_module( 'Thrift' => '0.8.0' ) ) {
print "yes!\n";
} else {
print "nooo ...\n";
}—
Reply to this email directly or view it on GitHub
#29.
from cpan-meta-requirements.
If 0.8.0 is 0.008000, why isn't 0.6 equal to 0.006 in "numeric"?
from cpan-meta-requirements.
0.6.0 is. But 0.6 isn't.
On Mon, Aug 3, 2015, 10:25 PM Mike Schilli [email protected] wrote:
If 0.8.0 is 0.008000, why isn't 0.6 equal to 0.006 in "numeric"?
—
Reply to this email directly or view it on GitHub
#29 (comment)
.
from cpan-meta-requirements.
So if a module author releases 0.6.1 after 0.6, this will break every module on CPAN requiring 0.5 and above?
from cpan-meta-requirements.
Correct. A CPAN dist shouldn't switch version number scheme, at least not
in the middle of minor releases.
Read more at
http://www.dagolden.com/index.php/369/version-numbers-should-be-boring/
On Mon, Aug 3, 2015, 10:32 PM Mike Schilli [email protected] wrote:
So if a module author releases 0.6.1 after 0.6, this will break every
module on CPAN requiring 0.5 and above?—
Reply to this email directly or view it on GitHub
#29 (comment)
.
from cpan-meta-requirements.
Okay, I'll fix my dependency on Thrift 0.6 to 0.6.1 and hope that the author won't revert to a two-number scheme. Thanks!
from cpan-meta-requirements.
Well, Thrift is still indexed to 0.8.0 rather than the new 0.9.0 release,
because its package statement was altered:
https://metacpan.org/source/GSLIN/Thrift-0.9.0//lib/Thrift.pm
Thrift 0.008000 G/GS/GSLIN/Thrift-0.8.0.tar.gz
Thrift::BinaryProtocol 0.009000 G/GS/GSLIN/Thrift-0.9.0.tar.gz
Thrift::BinaryProtocolFactory 0.009000 G/GS/GSLIN/Thrift-0.9.0.tar.gz
Thrift::BufferedTransport 0.009000 G/GS/GSLIN/Thrift-0.9.0.tar.gz
Thrift::BufferedTransportFactory 0.009000 G/GS/GSLIN/Thrift-0.9.0.tar.gz
Thrift::ForkingServer 0.009000 G/GS/GSLIN/Thrift-0.9.0.tar.gz
Thrift::FramedTransport 0.009000 G/GS/GSLIN/Thrift-0.9.0.tar.gz
Thrift::HttpClient 0.009000 G/GS/GSLIN/Thrift-0.9.0.tar.gz
On Mon, Aug 3, 2015 at 10:50 PM, Mike Schilli [email protected]
wrote:
Okay, I'll fix my dependency on Thrift 0.6 to 0.6.1 and hope that the
author won't revert to a two-number scheme. Thanks!—
Reply to this email directly or view it on GitHub
#29 (comment)
.
from cpan-meta-requirements.
Side note: this is why I recommend that people always use a leading v
when doing anything involving version tuples. It's much less confusing when someone drops the last part (as long as they keep the leading v
): v0.6.0
== v0.6
== 0.006
.
from cpan-meta-requirements.
Related Issues (20)
- test errors on 5.6 HOT 2
- Wrong installation into site on 5.8.9 [rt.cpan.org #88141] HOT 2
- version::vpp can't handle literal v-strings less than 3 chars HOT 1
- block a range of versions via '<=' and '>='
- add $name as optional param to bad_version_hook
- add \%options optional param to f_s_h
- coerce undef/zero-length versions to 0 in a_s_r
- "0.00" and "!= 0.00" now simplified as "0" and "!= 0" respectively. HOT 8
- Wrong CPAN::Meta::Requirements version HOT 4
- Publicize Range classes and objects HOT 2
- Explode @DAGOLDEN bundle in dist.ini HOT 7
- Descriptive error messages (hopefully an object!) to get which package gives conflicts HOT 4
- Ignore alpha in version comparison HOT 2
- strip underscore from versions when considering "accepts module" HOT 14
- Bad handling of small fractional numeric versions HOT 3
- Throws exception on lax version HOT 2
- Version string normalization destroys alpha version info HOT 14
- Remove the use of Carp::confess HOT 1
- Feature: Add support for requirements in the form of PackageURLs (purls) HOT 22
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cpan-meta-requirements.