Please make the MCE dependency optional about test-perl-critic HOT 12 OPEN

As I recall, the toolchain does not install recommended modules by default. I would prefer to have an opt-out instead of opt-in. So MCE would be required, unless you explicitly say you don't want it.

Would that be acceptable?

from test-perl-critic.

So MCE would be required, unless you explicitly say you don't want it.

I guess that depends on how you propose to implement that.

from test-perl-critic.

PS CPAN.pm does default to installing recommendations.

from test-perl-critic.

I guess that depends on how you propose to implement that.

Probably as a Build.PL command line option, with an environment variable hook. Other suggestions?

CPAN.pm does default to installing recommendations.

I didn't know that. Thanks for educating me. But cpanm still does not.

from test-perl-critic.

This is the canonical way to handle optional features with prompts:

in Makefile.PL:

my %WriteMakefileArgs = (
   ...
);

WriteMakefileArgs{PREREQ_PM}{'MCE'} = '0'
  if $ENV{PERL_MM_USE_DEFAULT} or prompt("install MCE (to allow parallelized tests)? [Y/n]", 'Y') =~ /^y/i;

WriteMakefileArgs{META_MERGE}{optional_features}{'parallel_testing'} = {
  description => 'parallel tests',
  prereqs => { runtime => { requires => { 'MCE' => '0' } } },
  x_default => 1,
};

WriteMakefile(%WriteMakefileArgs);

This will add the extra prereq unless the user specifically said 'no' to the
prompt (and in non-interactive installs, it defaults to 'yes').

I don't know how to do meta merging in Module::Build, but I wouldn't ever
recommend using MB anyway unless you really needed to (e.g. in an Alien dist).

from test-perl-critic.

This is the canonical way to handle optional features with prompts:

Thanks for that.

MB was a decision we made long ago, when MB was more fashionable. I could probably switch Test::Perl::Critic to EU::MM in the near future, but Perl::Critic itself will be harder to migrate.

from test-perl-critic.

we can help on #toolchain :)

from test-perl-critic.

++ for adding the MCE prereq to 'recommends' instead of 'requires'

from test-perl-critic.

from test-perl-critic.

Thank you. I had mistakenly mis-diagnosed an email reply on issue #707.

from test-perl-critic.

I'm certainly in favor of moving back to vanilla Makemaker. If I do that, I'll make MCE optional.

from test-perl-critic.

++

from test-perl-critic.