Code Monkey home page Code Monkey logo

Comments (10)

DanielHabenicht avatar DanielHabenicht commented on May 23, 2024 3

Baaam, made it. So it seems that testcafe has its own tsconfig.json which leads to ignoring my tsconfig.json.
Specifying my tsconfig.json in the testcaferc.json solved the problem:

{
  "tsConfigPath": "./tsconfig.e2e.json"
}

The key is to include esModuleInterop like so:

{
  "compilerOptions": {
    "esModuleInterop": true
  }
}

As this is an extension solely for testcafe specifying a tsconfig.json for this project which is compatible with the tsconfig.json of testcafe might also solve this problem.

from percy-testcafe.

wwilsman avatar wwilsman commented on May 23, 2024 1

So it looks like we inadvertently released the beta on the latest channel which is why you accidentally found yourself on the beta following the docs. I've since deprecated the first beta, released a new "previous" version to be tagged as latest, and now the new beta.2 lives on the @next channel.

Feel free to continue using the beta to help us vet out any bugs, but now you are able to install 0.2.1 and follow the guides on the site along with not having to install the new @percy/cli.

Back to the beta discussion, those types are found here and look to be valid as well as the type tests are passing without issue. Curious what might be going on to cause those type issues? 🤔

from percy-testcafe.

Robdel12 avatar Robdel12 commented on May 23, 2024

Hey @DanielHabenicht! Thanks for the issue -- it looks like you're using the latest beta version of this SDK. The docs for how to use the latest (beta) version can be found here: https://github.com/percy/percy-testcafe#usage There are a lot of big changes made to the SDK. One being the first argument to percySnapshot is now the name (and no longer the test instance).

You'll want to update your test to remove that first arg:

test("Finish intro screens", async (t) => {
  const nextButton = Selector("a").withAttribute("role", "button").child().withText("Weiter");
  const websiteText = Selector("html").textContent;

  const titleForIntro1 = "Willkommen bei der CovMap";

  await t.expect(websiteText).contains(titleForIntro1);
  await percySnapshot("Final Site");
});

The docs on docs.percy.io haven't been updated yet, you'll want to refer to the README for setup & config.

from percy-testcafe.

DanielHabenicht avatar DanielHabenicht commented on May 23, 2024

Thanks for the lighting fast feedback. Good to know that I should just read the master :)

Unfortunately your solution is bringing me back to #4 but this time if changed to import * as percySnapshot from ... Typescript errors:

This expression is not callable.
  Type 'typeof import("c:/Develop/GitHub/CovOpen/CovMapper/node_modules/@percy/testcafe/types/index")' has no call signatures.

There would be the option of calling percySnapshot.default but this also errors in TypeError: percySnapshot.default is not a function.

If run as js file the same Error as in my first comment surfaces.

from percy-testcafe.

DanielHabenicht avatar DanielHabenicht commented on May 23, 2024

I have looked into it a bit but I don't get it.
image
@percy/testcafe is imported fine, but Typescript transpiles it with a default function.
This has something to do with https://www.typescriptlang.org/tsconfig#esModuleInterop and that my project is using "module": "esnext", and yours is using the default tsconfig, thus "module": "commonjs",. I have already sunken to much time into it and will try the 0.2.1

from percy-testcafe.

DanielHabenicht avatar DanielHabenicht commented on May 23, 2024

Back to the error from the beginning :(
Switched to version 0.2.1 and everything is working almost fine.
Do you have any idea why certain parts of the background do not show in Percy screenshots?
We have a map in the background which does not show up...

from percy-testcafe.

Robdel12 avatar Robdel12 commented on May 23, 2024

I think I answered the map question via support -- is that right? :D I want to double check. If not send over a build link and we can take a closer look

from percy-testcafe.

DanielHabenicht avatar DanielHabenicht commented on May 23, 2024

yep, you did :) Thx again.

Any idea how to investigate the error?

from percy-testcafe.

github-actions avatar github-actions commented on May 23, 2024

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

from percy-testcafe.

github-actions avatar github-actions commented on May 23, 2024

This issue was closed because it has been stalled for 28 days with no activity.

from percy-testcafe.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.