It doesn't exit on wrong password about eslgo HOT 11 CLOSED

Hi @egorsmkv thanks for the bug report!

I believe I see the issue in the library, I do not return the error in Dial if authentication is unsuccessful.

I will fix this oversight shortly and test this error condition to ensure it's working properly.

from eslgo.

I will open another issue tracking this feature request and I will get it added in for the next release. Thanks @egorsmkv!

from eslgo.

Thanks, I wait to test it as well.

from eslgo.

@egorsmkv I have created what should fix this issue in #6 I have also created a release candidate tag for easier testing by yourself. You can switch to v1.3.3-rc to verify if it is working as expected.

I personally used this example to confirm things are working as intended:
https://github.com/percipia/eslgo/blob/close_fix/example/events/events.go

from eslgo.

Now, it closes as intented but now I am getting a randomized panic:

INFO[0003] Inbound Connection Disconnected              
ERRO[0010] failed to auth Content-Type: []string{"command/reply"}
Reply-Text: []string{"-ERR invalid"} 
panic: send on closed channel

goroutine 16 [running]:
github.com/percipia/eslgo.(*Conn).receiveLoop(0xc000090a20)
	/root/gopath/pkg/mod/github.com/percipia/[email protected]/connection.go:250 +0x299
created by github.com/percipia/eslgo.newConnection
	/root/gopath/pkg/mod/github.com/percipia/[email protected]/connection.go:67 +0x53a

from eslgo.

@egorsmkv It looks like this uncovered an underlying issue that wasn't shown due to the connection never exiting. I have pushed 1.3.3-rc2 that resolves this panic.

from eslgo.

It seems the issue is still here:

INFO[0019] Inbound Connection Disconnected              
ERRO[0022] failed to auth Reply-Text: []string{"-ERR invalid"}
Content-Type: []string{"command/reply"} 
panic: send on closed channel

goroutine 53 [running]:
github.com/percipia/eslgo.(*Conn).receiveLoop(0xc000158240)
	/root/gopath/pkg/mod/github.com/percipia/[email protected]/connection.go:252 +0x2b9
created by github.com/percipia/eslgo.newConnection
	/root/gopath/pkg/mod/github.com/percipia/[email protected]/connection.go:67 +0x53a

from eslgo.

Hi @egorsmkv

I resolved the race condition being caused by the early shutdown due to auth. Thank you for finding it, I'm sure we would've been bitten by it at some point in the future. Can you try 1.3.3-rc3 to verify that the issue is indeed gone for good this time?

from eslgo.

Now it properly works! Thank you, Andrew!

I just noticed that when the connection is closing here appears this error:

Error receiving message read tcp 127.0.0.1:50022->127.0.0.1:8021: use of closed network connection

and thisL

Failed to auth &{%!e(string=write) %!e(string=tcp) %!e(*net.TCPAddr=&{[127 0 0 1] 50026 }) %!e(*net.TCPAddr=&{[127 0 0 1] 8021 }) %!e(*errors.errorString=&{use of closed network connection})}

Is this normal?

from eslgo.

I'm glad to hear it! Thank you for raising the issue!

Those messages are normal around the shutdown of the connection. They are printed to the log just in case to help trace if there are any issues. I could potentially add in an option to either redirect the logging messages to a supplied logger or to quiet the internal library logs messages.

You can see where they happen here:
https://github.com/percipia/eslgo/blob/close_fix/connection.go#L243
https://github.com/percipia/eslgo/blob/close_fix/inbound.go#L68

from eslgo.

Yes, the ability to set own logger would be so useful!

I am using logrus inside my project so I can suppress these messages by setting the logging level.

from eslgo.