Code Monkey home page Code Monkey logo

Comments (3)

pennersr avatar pennersr commented on August 22, 2024

It's unclear to me why you would want to send a magic login link

It is not doing that... it is sending a "Hey, you don't have an account" mail. This (sending, or pretending to send) is needed to prevent account enumeration, and is good UX in case the user really thought he had an account but in fact did not.

from django-allauth.

jpwarren avatar jpwarren commented on August 22, 2024

Yes, I see. The account enumeration protection I understand.

I was thinking about the abuse case of an attacker using your site to send emails to a bunch of other people, spamming them to sign up to your site. That's not a new problem, though. It's the same challenge as password resets, hence using the same code, which makes sense.

And features like ACCOUNT_LOGIN_BY_CODE_MAX_ATTEMPTS help to guard against the abuse case, while preserving the use cases. Fair enough!

from django-allauth.

pennersr avatar pennersr commented on August 22, 2024

Fixed via 6206296

from django-allauth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.