Comments (3)
Thoughts:
- "representing an identifier that is uniquely identifies this account" -- this would only be usable by humans, as an email address and/or username could be modifiable over at the provider. Hence, this identifier is not to be used for other purposes...
- Given that it is just for display purposes, do we really need a new method, or could we just alter the
to_str()
method? - You likely put
return None
there so that there is some default, as changing this for all providers is quite a job. But, that leaves if with new method that sometimes gives a result, sometimes not... so that also points to not adding a new method and just alteringto_str()
.
from django-allauth.
That works for me. I'm happy with modifying to_str
instead of adding a new method get_identifier
. Let me know if you would welcome a pull request with this change.
from django-allauth.
Yes, the purpose of that to_str
is to return something human identifiable/recognizable, so feel free to improve it -- as long as there is a fallback to the old behavior in case the new field you are aiming for is not there.
from django-allauth.
Related Issues (20)
- Third-Party Login Failure on the production server but it works fine on the localhost HOT 1
- Users' email addresses can be leaked? HOT 1
- Steam Provider doesn't appear in socialaccounts in Response from _allauth/browser/v1/config HOT 1
- account.EmailAddress: (models.W036) MySQL does not support unique constraints with conditions ref 3385 HOT 3
- Version 0.63.4 broke Cognito integration HOT 2
- Signal for when both signup and email confirmation (if required) are completed HOT 5
- How to access 'Forgot your password?' anchor element. HOT 5
- Migration account.0006_emailaddress_lower throws unique error HOT 1
- Example in the documentation provides logout with 'GET' method HOT 1
- Not seeing commit in release tag(s) HOT 3
- Cannot specify allauth as a poetry git dependency HOT 1
- "hackable accounts/ url" changes (_accounts_redirect) to middleware results in SynchronousOnlyOperation error on ASGI HOT 2
- [MFA] Add totp svg to headless ManageTOTPView HOT 4
- [Headless] Customize headless.base.response.user_data HOT 1
- Django responds very slowly when user is signing up and first logging in HOT 4
- HTML Email Issue HOT 1
- Unable to authenticate using `X-Session-Token` HOT 2
- Cannot schedule new futures after interpreter shutdown HOT 2
- login and signup forms in the same page
- send real Email with docker in ubuntu server
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-allauth.