MultipleObjectsReturned with django-allauth 0.59.0 about django-allauth HOT 7 CLOSED

Can you paste a complete stack trace?

from django-allauth.

Traceback (most recent call last):
File "VIRTUALENV_PATH/python3.9/site-packages/django/core/handlers/exception.py", line 55, in inner
response = get_response(request)
File "VIRTUALENV_PATH/python3.9/site-packages/django/core/handlers/base.py", line 197, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "VIRTUALENV_PATH/python3.9/site-packages/allauth/socialaccount/providers/oauth2/views.py", line 84, in view
return self.dispatch(request, *args, **kwargs)
File "VIRTUALENV_PATH/python3.9/site-packages/allauth/socialaccount/providers/oauth2/views.py", line 162, in dispatch
return complete_social_login(request, login)
File "VIRTUALENV_PATH/python3.9/site-packages/allauth/socialaccount/helpers.py", line 208, in complete_social_login
sociallogin.lookup()
File "VIRTUALENV_PATH/python3.9/site-packages/allauth/socialaccount/models.py", line 282, in lookup
provider_id = self.account.get_provider().id
File "VIRTUALENV_PATH/python3.9/site-packages/allauth/socialaccount/models.py", line 141, in get_provider
provider = self._provider = adapter.get_provider(
File "VIRTUALENV_PATH/python3.9/site-packages/allauth/socialaccount/adapter.py", line 205, in get_provider
app = self.get_app(request, provider=provider)
File "VIRTUALENV_PATH/python3.9/site-packages/allauth/socialaccount/adapter.py", line 290, in get_app
raise MultipleObjectsReturned

Exception Type: MultipleObjectsReturned at /accounts/facebook/login/callback/

Raised during: allauth.socialaccount.providers.oauth2.views.view
Request information:
USER: AnonymousUser

Following the stack trace I see it might be here that the request gets lost?

Looking at the stack trace was definitely better than me randomly looking at the code. Thank you for pointing me to it.

from django-allauth.

The culprit is this line of code:

provider_id = self.account.get_provider().id

In order to return the provider we need to lookup the app, as that is a property of the provider instance (provider.app). But, in your case, there are multiple apps, so get_provider() gets confused. While passing request here (get_provider(request)) would solve the issue, we actually don't need the full provider here, only its ID. To be fixed.

from django-allauth.

Thank you very much, it makes much more sense now.

from django-allauth.

Upon closer inspection, there are other cases that need more than the ID. Fixed via f356138.

from django-allauth.

Can you try out the current main branch?

from django-allauth.

I'm sorry I thought I sent a reply to your question. It's working perfectly for me now!

from django-allauth.