Comments (5)
fscherf
commented on June 17, 2024
Hi @semigodking,
i am very sorry, you discoverd a bug here. At the moment i am working on a release that fixes the broken publish-subscribe system. I missed the code you wonder about.
As i started this project, all message encoding and decoding was part of a custom subclass of the aiohttp websocket class (therefore "ws").
We splitted this code in multiple libraries because we have a rpc client library now that needs message processing as well.
If you want to send a notification based on a request (no broadcasting) you use aiohttp_json_rpc.communication.JsonRpcRequest.send_notification now.
Thx for pointing this issue out, i fixed the wrong call and added a test.
from aiohttp-json-rpc.
semigodking
commented on June 17, 2024
Hi @fscherf,
About these two lines, i am wondering why they are needed. They send staled notification whenever a client subscribes a topic.
from aiohttp-json-rpc.
fscherf
commented on June 17, 2024
@semigodking
If you subscribe to a topic on which were notifications send you missed, you get the last one.
We call this 'state' and use it for progress informations on long running tasks.
So if you connect on 10% of the task you dont have to wait for 11% to see the current progress.
from aiohttp-json-rpc.
semigodking
commented on June 17, 2024
Looks like this feature is not acceptable by some time sensitive
applications.
…On Fri, Jun 15, 2018, 19:06 Florian Scherf ***@***.***> wrote:
@semigodking <https://github.com/semigodking>
If you subscribe to a topic on which were notifications send you missed,
you get the last one.
We call this 'state' and use it for progress informations on long running
tasks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB-rj_KmsTtIzyTTaPlglLIzTEGgY_cSks5t85UbgaJpZM4Uo54x>
.
from aiohttp-json-rpc.
fscherf
commented on June 17, 2024
you are right. you could make it configurable in a pull request :)
from aiohttp-json-rpc.
Related Issues (20)
- Can't use an alternate 'loop' and client seems to constrained to web-sockets only HOT 9
- Key Error trying to process implementation defined server errors HOT 4
- Can't cancel coroutine/future using JSON-RPC client HOT 5
- Enable cron builds in Travis CI HOT 8
- builtin funtions and C functions can not be used as RPC methods HOT 6
- Poor connection maintenance and exception strategy in `JsonRpcClient` HOT 1
- aiohttp 3.5 HOT 1
- Wrong examples HOT 2
- Getting 'Invalid response status' on all calls HOT 3
- Cannot handle more than one positional argument HOT 4
- Handle batch commands HOT 1
- POST requests implementation HOT 1
- Allow SSL context to be passed to JsonRpcClient.connect() HOT 2
- randomly InvalidStateError HOT 2
- PasswdAuthBackend: AttributeError: 'function' object has no attribute 'method' HOT 5
- concurrent.futures._base.TimeoutError HOT 4
- Handle_websocket_request method in JsonRpc class HOT 4
- ValueError: list.remove(x): x not in list ib rpc.py modle HOT 3
- concurrent.futures._base.TimeoutError occuring Randomly HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aiohttp-json-rpc.