Passing a TypedArray with an offset to importKey, the offset is ignored. about webcrypto HOT 4 CLOSED

I poked around over in https://github.com/PeculiarVentures/webcrypto-core and wrote a quick failing test:

  it("convert from offset Uint8Array", () => {
    const source = new Uint8Array([0,1,2,3,4,5,6,7,8,9])
    const offset = source.subarray(5, 10)
    const data = BufferSourceConverter.toUint8Array(offset)
    assert.equal(Convert.ToHex(data), '0506070809')
  })

The underlying issue here is that you are using the buffer of the provided view, rather than using the view. If someone provides a view as a parameter, the offset and length of that view must be respected and the underlying buffer should not be used directly as the key. Unfortunately, fixing this is likely going to be a pretty big task since it is a minor architectural change to how you deal with arbitrary input data.

It does appear that the MDN Documentation for importKey does not match what either Firefox or Chrome does. It says it takes an ArrayBuffer, but in reality it takes ArrayBuffer/TypedArray/DataView. I have submitted an update to MDN to correct this.

from webcrypto.

@MicahZoltu Thank you for pointing to this problem and shared information. I'll fix it shortly

from webcrypto.

@MicahZoltu I published @peculiar/[email protected]. Can you try it?

from webcrypto.

1.0.19 fixed the problem for me. Thanks!

from webcrypto.