Code Monkey home page Code Monkey logo

Comments (4)

pcorless avatar pcorless commented on August 17, 2024

Thanks for the feedback. As you noted there currently isn't an easy way to do a quick icon swap. I've been struggling myself in this department with some recent new toolbar additions. It's a lot of work to add new icon, rollover state makes it even worse.

The original icon set was created by a graphic designer and I've tried pretty hard to match the style a much as possible with new icons. I've wanted to create a new set for a long time that was a lot lower key, something more along the UI guide lines Gnome has produced. Another consideration is also a JavaFX which would allow for the use of SVG icons and CSS which in theory would simplify things.

I think it would be pretty easy to adjust for an icon set that doesn't have a rollover state and a better file name and directory scheme. When you have some time please submit a PR even if it's just a draft. I'd be interested in making the related changes and it's always nice get a bit of community feedback to help the process.

from icepdf.

a-leithner avatar a-leithner commented on August 17, 2024

Sure! I'll see what I can come up with over the course of the next couple of weeks.

As of late, FlatLaF has provided support for SVG icons in Swing. Obviously, depending on a whole LaF is something I wouldn't recommend, but I wonder if there is some code we could integrate (or depend on, if they provide a separate package for it) to load and render SVG files.

Speaking of renewing the icon set (though being a completely different consideration), I have used Material Design Icons lately, though I imagine they're laking some of the icons "messages" needed for a full-blown PDF viewer. Also, there's always the possibility to use some of the other free icon themes shipping with Gnome (Adwaita, I think) or KDE (Breeze) which are surely more complete. Other projects (like LibreOffice) do this too.

I'd be focussing on getting Icons swappable for now though, preserving the current icons. But I'm open to do some of that rework in the future too, if you want.

Finally, thanks for all the effort you've put into creating and maintaining this project; it's been very great to find for aforementioned application!

from icepdf.

pcorless avatar pcorless commented on August 17, 2024

Cool, I'll keep an eye out for progress. In the mean time I'll see if I can compile a list of matching icons, I totally forgot about the material design icons.

from icepdf.

a-leithner avatar a-leithner commented on August 17, 2024

I've come up with a system/API for customizable icons for the ICEpdf viewer in #347 – I hope that's somewhere along the lines of the kind of abstraction you're looking for here.

from icepdf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.