Comments (6)
klauer
commented on August 29, 2024
1
So much better!
Looks like the three of us agree it'd be a good thing overall - so go for it.
from pre-commit-hooks.
ZLLentz
commented on August 29, 2024
I'm in favor of .rst standards
from pre-commit-hooks.
klauer
commented on August 29, 2024
Have any sample output to share from one of our projects? Seems good in principle.
from pre-commit-hooks.
ZryletTC
commented on August 29, 2024
Here's a purposefully failed output from pcdshub.github.io. Still trying to figure out why it seems to split the files into two chunks (4 and 3).
(dev) PC92005:pcdshub.github.io pennebak$ pre-commit run --all-files
Don't commit to branch...................................................Passed
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check python ast.........................................................Passed
Check for case conflicts.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check for merge conflicts................................................Passed
Check for broken symlinks............................(no files to check)Skipped
Check Xml............................................(no files to check)Skipped
Check Yaml...............................................................Passed
doc8.....................................................................Passed
(dev) PC92005:pcdshub.github.io pennebak$ pre-commit run --all-files
Don't commit to branch...................................................Passed
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check python ast.........................................................Passed
Check for case conflicts.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check for merge conflicts................................................Passed
Check for broken symlinks............................(no files to check)Skipped
Check Xml............................................(no files to check)Skipped
Check Yaml...............................................................Passed
doc8.....................................................................Failed
- hook id: doc8
- exit code: 1
Scanning...
Validating...
source/overview.rst:8: D001 Line too long
========
Total files scanned = 4
Total files ignored = 0
Total accumulated errors = 1
Detailed error counts:
- doc8.checks.CheckCarriageReturn = 0
- doc8.checks.CheckIndentationNoTab = 0
- doc8.checks.CheckMaxLineLength = 1
- doc8.checks.CheckNewlineEndOfFile = 0
- doc8.checks.CheckTrailingWhitespace = 0
- doc8.checks.CheckValidity = 0
Scanning...
Validating...
========
Total files scanned = 3
Total files ignored = 0
Total accumulated errors = 0
Detailed error counts:
- doc8.checks.CheckCarriageReturn = 0
- doc8.checks.CheckIndentationNoTab = 0
- doc8.checks.CheckMaxLineLength = 0
- doc8.checks.CheckNewlineEndOfFile = 0
- doc8.checks.CheckTrailingWhitespace = 0
- doc8.checks.CheckValidity = 0
from pre-commit-hooks.
klauer
commented on August 29, 2024
That looks pretty good. Maybe lowering the verbosity would be a good default?
from pre-commit-hooks.
ZryletTC
commented on August 29, 2024
Yeah good idea. Here's with the --quiet arg
doc8.....................................................................Failed
- hook id: doc8
- exit code: 1
source/overview.rst:8: D001 Line too long
much shorter/cleaner 👍
from pre-commit-hooks.
Related Issues (14)
- Decide on standard configuration for Python HOT 11
- Decide on standard configuration for Beckhoff TwinCAT/PLC projects HOT 5
- Investigate continuous integration HOT 1
- TwinCAT XAE Shell Built-in Git Integration
- Look into automatic enable HOT 10
- TwinCAT POU Pre/Post Newlines Hook HOT 3
- miniconda hashbang erroneously committed (?)
- Add localization-supported DUT file extension to the list of source code files to be formatted (.TcTLEO) HOT 1
- Add .pre-comit-config.yaml settings to README HOT 2
- XML reformatter sometimes requires multiple tries HOT 3
- Add pytmc pragma linting as a pre-commit hook
- Clean up version handling and python packaging HOT 1
- Idea: hook to check for mixed and/or pinned TwinCAT versions HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pre-commit-hooks.