Cancelable promises about redux-promise-middleware HOT 6 CLOSED

Yeh the CANCELLED action type sounds perfect

from redux-promise-middleware.

No, it's a terrible idea. Cancelling is another kind of rejection. Such change would introduce the whole universe of brittleness.

from redux-promise-middleware.

No, it's a terrible idea. Cancelling is another kind of rejection.

From the proposal: "canceled is a third state, alongside fulfilled and rejected."

from redux-promise-middleware.

And that's exactly what is wrong. It's completely against the promises principle. Hey, imagine you gave a promise to somehow. It can be resolved or rejected. Canceling is a lie in the contract.

from redux-promise-middleware.

One of the major problems with promises is that they can't be cancelled. This is why many people have turned to observables.

Cancelling is a state that is decided by the consumer of the promise, not by the promise itself (such as rejected). This is a great way to avoid things like DOM updates as a result of the promise when the necessary nodes were unmounted between the promise being started and being resolved.

Cancelling is good and does not introduce brittleness.

The only concern I can think of is when there are multiple consumers of a promise. But if they all handle the cancelled state appropriately, then it should be fine.

from redux-promise-middleware.

This proposal has been withdrawn. Closing the issue.

from redux-promise-middleware.