Comments (10)
Not sure what to do. The UI is not meant to be used by untrusted people. It is backend stuff and only an admin or a manager have access to it. They want do xss injections, I hope.
The api must not be publicly accessible too.
Though the security topic is not solved yet in Payum. It is PoC and everything is public for now.
from payumserver.
Thank for raising starting discussion on this topic.
from payumserver.
What problems did you face trying to install payumserver?
from payumserver.
Strict data validation input should clear this up.
from payumserver.
What do you mean by Strict data validation
?
from payumserver.
Giving some ideas to harden security.
- Selected input exists in the list for the current user.
- Casting it to an integer if it's an auto-incremental index will clear up some problems as it will change the whole string to '0'.
- Additional checks could be look up if value it exists within the existing range of identifiers.
It will make the code slower, but more secure.. and that's what we want for Payum.
from payumserver.
Why should we bother about it. The functionality is accessible by limited set of users. They work on your company.
We can do changes audit. What was changed and by what user.
from payumserver.
Yeah just as idea. I agree with you it's overkill @makasim.
from payumserver.
Hey,
i already fixed this issue in my pull-request.
Just an example:
Jack (a client) wants Barbara (a secretary) to add a gateway. I a mail he sends her the name (a xss) and the xss sends information (user token etc.) to Jack.
I understood that the Gatway is only accessible by a limited set of users but the security awareness of these users is important.
I always ask myselfe "what if my mum would be the secretary?"
from payumserver.
I gave it one more thought and now I tend to think we have to sanitize it. Maybe a regexp validation rule for some fields would be the way to go.
from payumserver.
Related Issues (20)
- Demo does not work for PayPal HOT 1
- TODOs HOT 1
- Fix Fatal error: Call to a member function createConfig() on a non-object in ../Payum/PayumServer/vendor/payum/payum/src/Payum/Core/Bridge/Symfony/Form/Type/GatewayConfigType.php on line 64 HOT 3
- Complete solution.
- Replace Doctrine with Yadm
- Register other gateways HOT 3
- Api documentation HOT 10
- [UI] The url set in setting is not changed till you reload the page. HOT 1
- Demo does not recognize the server url with custom port.
- [UI] payum.js is not loaded properly HOT 1
- Gateways are duplicated in select box. HOT 1
- Demo is not working HOT 8
- docker-compose example in readme out of date HOT 1
- Docker image doesn't work HOT 1
- tag it using semver
- payum/server missing DOM extension HOT 1
- Fatal error: Uncaught RuntimeException: APP_ENV environment variable is not defined.
- List of requirements
- have you thought about how to extend phar with composer or other phar packages? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from payumserver.