Comments (4)
This is a good point! Let me think about it - really the only reason for keeping 2 spaces for tab width is formatting for JSON files. I might just add an override for *.json
and set the default to 4.
from foundry-template.
I ended up doing something else - I have kept the default tabWidth
to 2 but I have also added an override for Solidity to use 4, like this:
overrides:
- files: ["*.sol"]
options:
tabWidth: 4
Otherwise, I would have had to add quite a few overrides:
- files: ["*.json", "*.md", "*.yml"]
Even if Prettier is not run over Solidity files, this should make the template more robust for end users, since it will prevent accidental re-formatting when the VSCode settings are not configured on a per-language basis.
Thanks for opening this issue, @vmaark.
from foundry-template.
This is not an issue with the template itself. You can refer to the Formatter section of the "Integrating with Foundry" guide of the Foundry Book for how to configure VSCode to not run Prettier on Solidity files. In short, you have to add this to your VSCode settings:
"[solidity]": {
"editor.defaultFormatter": "JuanBlanco.vscode-solidity"
},
from foundry-template.
That may be true, but it would still be better not to use different values for tabwidth.
from foundry-template.
Related Issues (20)
- Provide `--via-ir` set up
- Description not added in the "package.json" file
- `rename.sh` and `create.yml` CI files not removed
- Can't run tests HOT 2
- Upgrade to the latest Solidity HOT 2
- Message: failed to extract foundry config: HOT 3
- Failed to create project from `forge init` command HOT 3
- Add forge coverage commands to scripts HOT 1
- Integrate BTT
- Move away from PNPM HOT 4
- Add GitPod config
- Branch with hardhat on the side of foundry for integration testing HOT 1
- PRBTest.sol breaks Vm.Log ? HOT 1
- Move to Forge Std to avoid `Vm` interface clashes
- genhtml: command not found | error: script "test:coverage:report" exited with code 127 HOT 1
- Fix prettier glob pattern in package.json HOT 6
- Bun run lint failing on prettier-plugin-solidity HOT 2
- Running `forge init --template PaulRBerg/foundry-template` doesn't work HOT 1
- Use "forge fmt" instead of Prettier HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from foundry-template.