Code Monkey home page Code Monkey logo

Comments (7)

PaulNieuwelaar avatar PaulNieuwelaar commented on May 26, 2024 1

No changes required, so it's just the current version 2.1. Things like "parent." will still get flagged by the automated verification process, but you should be able to reference the Alert.js app source page to show that it's already been approved.

from alertjs.

PaulNieuwelaar avatar PaulNieuwelaar commented on May 26, 2024

Hi, I've just tested some of the functions again on V9, in particular the getCrmWindow and getIFrameWindow and they both seem to be returning the correct objects for me. Could you share the code snippet you're using to display the alert? And if you're displaying a web resource, could you share any code that references back to the Alert.js library? Also, at what point does the error occur? Cheers, Paul

from alertjs.

forceworks avatar forceworks commented on May 26, 2024

from alertjs.

PaulNieuwelaar avatar PaulNieuwelaar commented on May 26, 2024

Ah yup, in this case it's only using window.parent to get access to jQuery, and it handles both scenarios of turbo forms on/off. It also appends the alert wrapper directly to the top frame, so it doesn't matter about the form context etc, it will work regardless. This library is still technically unsupported as it manipulates the DOM, but it's done in a way that has very low dependencies on anything CRM, so it "should" continue to work going forward. Cheers for the feedback πŸ˜ƒ - Paul

from alertjs.

amervitz avatar amervitz commented on May 26, 2024

A ramification of the unsupported techniques used is Microsoft isn’t allowing submissions to AppSource with this library included as a dependency. I’d suggest this caveat be disclosed in the readme.

from alertjs.

PaulNieuwelaar avatar PaulNieuwelaar commented on May 26, 2024

Hi Alan, I'm pleased to announce that Alert.js v2.1 has now been approved for App Source, so you should have no problems listing this as a dependency now πŸ˜ƒ- Paul

from alertjs.

amervitz avatar amervitz commented on May 26, 2024

@PaulNieuwelaar that's great news. Were there any changes required (and which commit has the changes?) or are the AppSource certification team now allowing the techniques that are taken? It would be very helpful to reference something if this gets flagged in the future during certification.

from alertjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.