Comments (4)
This issue introduces the concept of a User. Authenticated endpoints (which include all endpoints except signup and login) will now need to be Auth'd.
All services will have to take a user. For example, if someone POSTs a new pet, we should associate the user id of the user who created it. Similarly, when someone POSTS a new order, we should save the user id on the order as well.
I am still working through the particulars of TSec, may reach out for some help.
from scala-pet-store.
@paulcleary @zakpatterson I wanted to give a try to TSec
so I started working on the issue. I have the implementation almost ready but I python is a no-no for me. Do you want me to leave PR without the Python part for someone who is willing to help with it ? Or nah ?
from scala-pet-store.
I think starting a work-in-progress PR for the TSec stuff, and just leaving off the integration testing for it is a great idea.
As an aside, I do think the python has instructive value for people that come to the project from a python background. I also think adding integration testing using http4s's client libraries would be valuable. Once integration testing is built out using http4s I think there would be a case to be made to drop the python one since maintaining both would be annoying.
from scala-pet-store.
I agree. It would be great for someone new to fs2 to build integration tests using the streaming http client from http4s. Although you could just run the non-streaming one which is designed specifically for testing.
I'll try to finish and polish the work-in-progress PR about TSec during the next week. Some feedback will be nice :)
from scala-pet-store.
Related Issues (20)
- Use `requests.request(params=xxx)` for python client
- Add scala-steward to project HOT 6
- Switch to circe-config HOT 5
- Travis is not connected HOT 4
- Dockerize sbt build
- Add github pages deployment to travis HOT 2
- add Scala 2.13 crossbuild HOT 3
- Application gets blocked on db connection acquisition if more than 10 concurrent clients connect HOT 3
- Implement Tracing and Stats
- question: Why Resource in Server.scala? HOT 2
- n HOT 3
- Having problem with sbt compile HOT 3
- Thanks note and request for an note HOT 1
- Change Python version in README HOT 1
- Scalacheck spots error in PetEndpoints HOT 1
- Pet and Order status can get out of sync
- Have you considered the library freestyle?
- SQLPagination drops SQL parameters HOT 1
- Scala 2.13.6 Unused Parameter Value for Higher Kinded Type HOT 1
- Remove monad transformer return types from algebras HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scala-pet-store.