debounce calls to window resize handler? about ng-fittext.js HOT 13 CLOSED

It's something I've been tossing up. Cheers for raising the issue.

from ng-fittext.js.

Cheers for considering! What's the downside, just having to implement debounce? Looks like lodash's is ~100 lines, but we could implement it less generically in fewer.

from ng-fittext.js.

Yeah, it was just a matter of including it as succinctly as possible...

from ng-fittext.js.

Added a minified version of Underscore's debounce function.

from ng-fittext.js.

Nice :)

from ng-fittext.js.

Just an idea: Think it's worth making debounce an option, so users can opt out of it, or supply a different delay?

from ng-fittext.js.

Unsure how to accomplish settings which will effect all directives (without adding an additional wrapper) - unless you simply mean making the setting more accessible within the file via a var up top?

from ng-fittext.js.

Does https://github.com/angular-ui/bootstrap/blob/master/src/pagination/pagination.js provide a good example of how to offer directive configuration? (Search that as well as the docs at http://angular-ui.github.io/bootstrap/ for "paginationConfig").

from ng-fittext.js.

Don't really understand a config that gets blown away whenever an update to the module comes along... Nor does it make sense that these settings are attributes for each directive. Needs to be independent and global - which seems to suggest setting attributes on a parent directive/controller

from ng-fittext.js.

@Skivvies added the config for you, looking into how this can be extended (in a similar fashion to jQuery plugins)

from ng-fittext.js.

Thanks @patrickmarabeas. I'm more familiar with the Angular ecosystem than jQuery. I'll keep an eye out for what you do to see what you mean.

Worth updating the README with an example of overriding the default debounce?

from ng-fittext.js.

@Skivvies see https://github.com/patrickmarabeas/jQuery-FontSpy.js

$('.bannerTextChecked').fontSpy({
    onLoad: 'hideMe',
    onFail: 'fontFail anotherClass'
});

extends:
(https://github.com/patrickmarabeas/jQuery-FontSpy.js/blob/master/jQuery-FontSpy.js#L24)

var defaults = {
    font: $element.css("font-family"),
    onLoad: '',
    onFail: '',
    testFont: 'Comic Sans MS',
    testString: 'QW@HhsXJ',
    delay: 50,
    timeOut: 2500
};

from ng-fittext.js.

@Skivvies It has been implemented if you're interested. README has been updated as well : )

from ng-fittext.js.