Comments (3)
I've just pushed a commit to avoid setting secret_token
for Rails 5.2 onwards (d22798d). Also, secret_key_base
is already being set, so for your temporary workaround, you don't need to worry about that.
Thanks for reporting the issue :) I'll push a gem release out in the next week or so.
from combustion.
0.9.1 is now released with this fix :)
from combustion.
In my own app, which runs CI in multiple rails versions (not using appraisal
, just my own hack, appraisal probably has it's own way...), I get rid of deprecation message like this:
Combustion.initialize! :all do
case "#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}"
when "5.0"
# avoid deprecation notice
config.active_record.time_zone_aware_types = [:datetime]
when "5.2"
config.secret_key_base = config.secret_token
config.secret_token = nil
end
end
from combustion.
Related Issues (20)
- Typo in README.md HOT 1
- Error Sprockets::Railtie::ManifestNeededError HOT 7
- Loosen (or bump) dependency on rubocop? HOT 2
- `no implicit conversion of nil into String (TypeError)` with 1.2.0 HOT 4
- deprecation on rails edge involving db configuration to_h HOT 3
- Drop `git` in gemspec? HOT 1
- Don't know how to fix rake tasks in engine HOT 3
- uninitialized constant.. HOT 2
- Support for webpacker + capybara ? HOT 7
- Getting a NameError on `ActiveRecord` for project not initialising activerecord HOT 4
- Rails edge failure involving sprockets-rails HOT 1
- Rails 7.0.0.alpha1 deprecation warning involving `connection_handlers` HOT 4
- legacy_connection_handling= no longer supported in Rails main/edge HOT 3
- combustion 1.3.6 fails to require sprockets for Rails 6.1.1+ HOT 1
- Open up for extensibility HOT 4
- ActiveRecord::Base.clear_active_connections! is deprecated in current edge Rails 7.1 HOT 2
- Error while building the package HOT 2
- Maybe release? Rails 6 is broken( HOT 1
- Combustion failing for me on CI with Rails 5.2.2.1: tmp/development_secret.txt HOT 3
- Rails 6 - ActiveRecord::MigrationContext.new expects 2 args HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from combustion.