Comments (13)
I noticed that it's not just sometimes working, sometimes not working, but it seems to never work anymore. I created a PR for it, no full release yet, but I still have a little hope that GH will fix this issue in the next days.
In the meantime, you should be able to use this version, which re-adds the previously removed feature of branch deletion after merge:
steps:
- name: automerge
uses: "pascalgn/automerge-action@8bab27d2212be1b3a0767ee5ee58f7a255b38812"
from automerge-action.
The action just calls merge
: https://github.com/pascalgn/automerge-action/blob/master/lib/merge.js#L175
I'm pretty sure it's an issue on GH's side. I ran the action locally yesterday, for testing the MERGE_RETRY parameters and the branch was deleted successfully. To be honest, I'm not particularly surprised, I've ran into a lot of small bugs with the GH actions so far.
If you find any issues, I'm happy to fix it, but I think this is an issue on GH's side.
from automerge-action.
The PR is based on the latest master, so the retry configuration should also be included! 👍
from automerge-action.
The funny thing is that I never experienced issues with public repositories. For me, the issue only occurred in private repositories, so even if I see any issues again, I'm quite sure it won't be in a public repository. But let's just hope that it's fixed now :) Thanks for letting me know!
from automerge-action.
We are having this issue as well
from automerge-action.
Confirmed that merging a pull request via the V3 api follows the repos rules. @pascalgn Any idea if your action does anything differently :)
from automerge-action.
Aah okay i see, thanks for jumping on this very quickly! Unfortunately we also using the retry stuff you just added, so just gonna wait on the PR merging. Thanks :)
from automerge-action.
Even though GH support never got back to me, I think this has been fixed now. At least we had a few PRs closed where the branches were deleted, too. Can anyone confirm this?
from automerge-action.
I'm closing this now, but feel free to reopen it if you're facing problems again!
from automerge-action.
So I just tested it in a private repository and for a private repository on my personal account the automatic branch deletion didn't work. GH support, as usual, wasn't helpful either.
So I've now added a new option MERGE_DELETE_BRANCH (see current README), with default false. Set it like MERGE_DELETE_BRANCH: "true"
to have the action delete branches after merge!
from automerge-action.
After three month of mail contact with github support (just 6 mails in total), they finally confirmed the issue. I asked them for a timeline will update here in case they reply.
Thx for the option as a work around!
from automerge-action.
I recieved this mail on the first of February:
Thanks for hanging in there. We received an update internally that we'd like to share here. Our engineers deployed an update that ensures that pull requests merged by GitHub App installations (including the GitHub Actions App via the GITHUB_TOKEN) should be automatically deleted.
If you're seeing any behavior to the contrary, you're welcome to write back referencing an example in the form of a public repository and we'll do our best to help.
In case you have any public example at hand let me know, so I can forward the information :)
from automerge-action.
Also with your action when the deletion is enabled, I will not invest time to disable it, just to check if it's fixed...
from automerge-action.
Related Issues (20)
- Can't change log level to debug. HOT 2
- ΒUG: Unable to bypass branch protection rules HOT 5
- Old configuration option present: LABELS HOT 2
- I am coping HOT 6
- What does BASE_BRANCHES do? HOT 2
- UPDATE_RETRY_SLEEP and UPDATE_RETRIES does not respect label HOT 2
- Gotcha for new repos HOT 2
- Missing commit if merge happens right after it HOT 1
- Question: will automerge bypass branch protections? HOT 1
- Merges PRs when mergeable_state = undefined HOT 2
- Failed to merge PR: Changes must be made through the merge queue HOT 2
- ERROR Resource not accessible by integration HOT 7
- bug: Invalid workflow file
- ERROR fetch is not set. Please pass a fetch implementation as new Octokit({ request: { fetch }}). Learn more at https://github.com/octokit/octokit.js/#fetch-missing HOT 1
- Add 'pull-request-title-and-commit-details' option for MERGE_COMMIT_MESSAGE HOT 2
- Append PR number to merge commit message HOT 2
- Questions about the process with error: Old configuration option present: LABELS HOT 1
- Update more than 10 PRs in a run HOT 3
- PAT not used when merging PRs
- Add MERGE_FILTER_AUTHORS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from automerge-action.