I am learning how to efficiently save objects in batch and how to properly handle the

Do you mean what you posted <a href="https://community.parseplatform.org/t/both-custom

handling error in .saveAll(),about parse-community/parse-swift

lsmilek1 commented on May 18, 2024 1

Do you mean what you posted here, right?

I will switch to server generated Ids as I have basically only one class that got custom objectId to save few cloud code queries. Therefore I believe this situation won't happen anymore as I see that createCommand() and updateCommand() do not throw and saveCommand() has only the .missingObjectId()

Parse-Swift/Sources/ParseSwift/API/API+Commands.swift

Lines 333 to 363 in fca7ab1

    
           // MARK: Saving ParseObjects 
        
           static func saveCommand<T>(_ object: T) throws -> API.Command<T, T> where T: ParseObject { 
        
               if ParseSwift.configuration.allowCustomObjectId && object.objectId == nil { 
        
                   throw ParseError(code: .missingObjectId, message: "objectId must not be nil") 
        
               } 
        
               if object.isSaved { 
        
                   return updateCommand(object) 
        
               } 
        
               return createCommand(object) 
        
           } 
        
           // MARK: Saving ParseObjects - private 
        
           private static func createCommand<T>(_ object: T) -> API.Command<T, T> where T: ParseObject { 
        
               let mapper = { (data) -> T in 
        
                   try ParseCoding.jsonDecoder().decode(SaveResponse.self, from: data).apply(to: object) 
        
               } 
        
               return API.Command<T, T>(method: .POST, 
        
                                        path: object.endpoint(.POST), 
        
                                        body: object, 
        
                                        mapper: mapper) 
        
           } 
        
           private static func updateCommand<T>(_ object: T) -> API.Command<T, T> where T: ParseObject { 
        
               let mapper = { (data) -> T in 
        
                   try ParseCoding.jsonDecoder().decode(UpdateResponse.self, from: data).apply(to: object) 
        
               } 
        
               return API.Command<T, T>(method: .PUT, 
        
                                        path: object.endpoint, 
        
                                        body: object, 
        
                                        mapper: mapper) 
        
           }

As mixed generated+custom objectId is not supported, do you think that such enhancement would be of any use? I believe we can close this topic, otherwise it would make more sense to support the mixed environment also?

from parse-swift.

cbaker6 commented on May 18, 2024

It seems like you are hitting this particular situation because of what I posted here.

I recommend choosing one of the options I mentioned. The try is throwing correctly:

Parse-Swift/Sources/ParseSwift/Objects/ParseObject.swift

Line 223 in fca7ab1

let commands = try map { try $0.saveCommand() }

If you want to submit a PR and attempt to identify the specific object that throws, I will review it, but attempting to save mixed environment custom objectId's isn't recommended and not supported by the SDK.

from parse-swift.

cbaker6 commented on May 18, 2024

Do you mean what you posted here, right?

Yes

As mixed generated+custom objectId is not supported, do you think that such enhancement would be of any use?

Posting my answer from here for future reference.

I believe we can close this topic

Feel free to close if you don't have any more questions.

from parse-swift.

parse-github-assistant commented on May 18, 2024

The label type:feature cannot be used in combination with type:improvement.

from parse-swift.

handling error in .saveAll() about parse-swift HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// MARK: Saving ParseObjects
	static func saveCommand<T>(_ object: T) throws -> API.Command<T, T> where T: ParseObject {
	if ParseSwift.configuration.allowCustomObjectId && object.objectId == nil {
	throw ParseError(code: .missingObjectId, message: "objectId must not be nil")
	}
	if object.isSaved {
	return updateCommand(object)
	}
	return createCommand(object)
	}

	// MARK: Saving ParseObjects - private
	private static func createCommand<T>(_ object: T) -> API.Command<T, T> where T: ParseObject {
	let mapper = { (data) -> T in
	try ParseCoding.jsonDecoder().decode(SaveResponse.self, from: data).apply(to: object)
	}
	return API.Command<T, T>(method: .POST,
	path: object.endpoint(.POST),
	body: object,
	mapper: mapper)
	}

	private static func updateCommand<T>(_ object: T) -> API.Command<T, T> where T: ParseObject {
	let mapper = { (data) -> T in
	try ParseCoding.jsonDecoder().decode(UpdateResponse.self, from: data).apply(to: object)
	}
	return API.Command<T, T>(method: .PUT,
	path: object.endpoint,
	body: object,
	mapper: mapper)
	}