Comments (11)
Fixed in vimeo/psalm@f096468
from airship.
You can do psalm --config=somefile.xml
from airship.
Relatedly, this curious chunk of code was flagged by latest Psalm dev-master
.
from airship.
Oh, I should probably change null
to []
? (Composer still hasn't updated.)
from airship.
more the if (!\is_array($data)) {
check on something that is definitely an array (because of the cast)
from airship.
Is there any chance we can just make the is_*()
functions excluded from type errors?
from airship.
They should be excluded when the type comes from a docblock (as opposed to language-level check). I think the difference here is that the if
is inside a loop, and I imagine I introduced a regression with vimeo/psalm#115. Will fix momentarily.
But still, how can that if statement ever be true?
from airship.
It can't ever be true; it's dead code. I'm removing it in a few seconds. :)
from airship.
Left to do before this can be closed (mostly meant as a note to myself so the next time I look through open issues for things to work on, I don't need to try to refresh my own memory):
- Find out if Psalm can be coerced into specifying a different .xml file from its CLI arguments.
- If yes, create a psalm.xml for each Cabin.
- If no, rename the existing psalm.xml file and rapidly create/remove symlinks to make it behave. Also, create a psalm.sh script to facilitate this for non-Travis testing.
from airship.
Perfect! Thanks. :)
from airship.
If you're running --diff
builds locally you'll need to specify different cache directories for them, but I think your codebase is small enough that --diff
builds aren't necessary.
from airship.
Related Issues (20)
- PHP Warning: symlink(): File exists in /src/Installer/Commands.php on line 41 HOT 1
- Version 2.0.0 is postponed until PHP 7.2
- Version 2: Better Naming Conventions HOT 1
- Automated Vulnerability Scanning
- Consistent Use of Regular Expressions
- Prevent super long email addresses
- For admins, the authors List should show yours first HOT 1
- Can't Install on CentOS 7? HOT 3
- Intent to Abandon Version 1 HOT 2
- Airship 2 doesn't see sodium from PHP 7.2 HOT 2
- "Outdated Version of Libsodium" notice from public/launch.php on PHP 7.2 HOT 4
- "Undefined index: email" when trying to launch airship HOT 3
- Keyggdrasil failed, Automatic update - signature failure, Call to undefined function textdomain() HOT 10
- Insecure links and loading HOT 9
- Tear Down Keyggdrasil, use a Chronicle Instead
- Non-Blocking I/O Servers Support ( Swoole, ReactPHP, Amp ... etc ) HOT 4
- Background on Codebase
- CSRF Array to String Error
- blank screen after creating account HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from airship.