Code Monkey home page Code Monkey logo

Comments (21)

nvb-uy avatar nvb-uy commented on June 10, 2024

Must also mention that, at first I thought this was a krypton issue so I removed it, but the error persisted.

from velocity.

Warriorrrr avatar Warriorrrr commented on June 10, 2024

Does it show the exact same error even with krypton removed? It might be useful to start the proxy with -Dvelocity.packet-decode-logging=true or enabling debug on the backend to see if it says anything in the logs

from velocity.

nvb-uy avatar nvb-uy commented on June 10, 2024

Yes, the error persists even without kyrpton, I'll try the debug in a bit.

I also want to point out that I did get this "fixed", by re-enabling packet compression, but I get kicked 2 seconds after joining with this error
ERROR

And the only print on the server's console is

[11.01 19:28:37] [Disconnect] ElocinDev has disconnected, reasonDisconnected
[11.01 19:28:37] [Server] [Server thread/INFO]: ElocinDev left the game
[11.01 19:28:37] [Server] [Server thread/INFO]: remove player wand

On the proxy it only shows:

[11.01 19:28:33] [Server] [INFO] [connected player] ElocinDev (/*****) has connected
[11.01 19:28:33] [Server] [INFO] [server connection] ElocinDev -> lobby has connected
[11.01 19:28:37] [Server] [INFO] [connected player] ElocinDev (/*****) has disconnected: §cYour connection to lobby encountered a problem.

from velocity.

nvb-uy avatar nvb-uy commented on June 10, 2024

This is what's shown now in the proxy

[11.01 19:54:55] [Server] [ERROR] [connected player] ElocinDev (/*****): unable to connect to server lobby
[11.01 19:54:55] [Server] io.netty.channel.AbstractChannel$AnnotatedConnectExceptionfinishConnect(..) failed: Connection refused: /*****
[11.01 19:54:55] [Server] Caused byjava.net.ConnectException: finishConnect(..) failed: Connection refused
[11.01 19:54:55] [Server] 	at io.netty.channel.unix.Errors.newConnectException0(Errors.java:166) ~[customjava17.jar:3.3.0-SNAPSHOT (git-408b420a-b316)]
[11.01 19:54:55] [Server] 	at io.netty.channel.unix.Errors.handleConnectErrno(Errors.java:131) ~[customjava17.jar:3.3.0-SNAPSHOT (git-408b420a-b316)]
[11.01 19:54:55] [Server] 	at io.netty.channel.unix.Socket.finishConnect(Socket.java:359) ~[customjava17.jar:3.3.0-SNAPSHOT (git-408b420a-b316)]
[11.01 19:54:55] [Server] 	at io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.doFinishConnect(AbstractEpollChannel.java:710) ~[customjava17.jar:3.3.0-SNAPSHOT (git-408b420a-b316)]
[11.01 19:54:55] [Server] 	at io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.finishConnect(AbstractEpollChannel.java:687) ~[customjava17.jar:3.3.0-SNAPSHOT (git-408b420a-b316)]
[11.01 19:54:55] [Server] 	at io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.epollOutReady(AbstractEpollChannel.java:567) ~[customjava17.jar:3.3.0-SNAPSHOT (git-408b420a-b316)]
[11.01 19:54:55] [Server] 	at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:499) ~[customjava17.jar:3.3.0-SNAPSHOT (git-408b420a-b316)]
[11.01 19:54:55] [Server] 	at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:407) ~[customjava17.jar:3.3.0-SNAPSHOT (git-408b420a-b316)]
[11.01 19:54:55] [Server] 	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[customjava17.jar:3.3.0-SNAPSHOT (git-408b420a-b316)]
[11.01 19:54:55] [Server] 	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[customjava17.jar:3.3.0-SNAPSHOT (git-408b420a-b316)]
[11.01 19:54:55] [Server] 	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[customjava17.jar:3.3.0-SNAPSHOT (git-408b420a-b316)]
[11.01 19:54:55] [Server] 	at java.lang.Thread.run(Thread.java:833) [?:?]
[11.01 19:54:55] [Server] [INFO] [connected player] ElocinDev (/*****) has disconnected: §cUnable to connect you to lobby. Please try again later.

from velocity.

electronicboy avatar electronicboy commented on June 10, 2024

connection refused just says that the target host refused the connection, that is out of bounds of velocity

from velocity.

nvb-uy avatar nvb-uy commented on June 10, 2024

Yet this only happens with Velocity... going back to a simple server works just fine...

from velocity.

electronicboy avatar electronicboy commented on June 10, 2024

connection refused is generally down to a network configuration issue, velocity itself has 0 control over your network and it's setup; Outside of that, your OG issue is however different, but, without much to work on here, theres little we can say or look into, we do not have the capacity to start debugging issues surrounding mod packs unless people can isolate it down to specific behaviors which are not instances of mods breaking the vanilla protocol spec

from velocity.

nvb-uy avatar nvb-uy commented on June 10, 2024

After enabling the debug logging, here's the issue:

[18:39:50 ERROR]: [server connection] newtykins -> lobby: exception encountered in com.velocitypowered.proxy.connection.backend.BackendPlaySessionHandler@24b2045f
io.netty.handler.codec.CorruptedFrameException: Uncompressed size 8734075 exceeds hard threshold of 8388608

from velocity.

electronicboy avatar electronicboy commented on June 10, 2024

So, you have a packet which exceeds the maximum packet size allowed by the vanilla protocol spec

from velocity.

nvb-uy avatar nvb-uy commented on June 10, 2024

The modpack currently uses ETP which increases the limit and allows issues like these to not happen, iirc this is caused by a REI packet, at least outside of the proxy relation

https://www.curseforge.com/minecraft/mc-mods/extra-thicc-packets

Is there any plugin or anything that could maybe increase the limit for the proxy? As this definetly works per-server at least

from velocity.

electronicboy avatar electronicboy commented on June 10, 2024

No, not afaik, we make many assumptions based upon these limits and adding a means to disable that limit is not something we can do blindly

from velocity.

nvb-uy avatar nvb-uy commented on June 10, 2024

It would be nice at least for modded servers, as a lot of modpacks require mods like these. I'll sniff the packets to look to the faulty one in the meantime, but an option to increase its maximum size would be ideal, there's no actual need to put it to the max integer value, but giving a choice for people to choose their own limit when things like these happens

from velocity.

electronicboy avatar electronicboy commented on June 10, 2024

there are technical caveats which arise elsewhere due to the design of the protocol which stem from this, could maybe 1.5x the limit safely, but too much beyond that will start causing some issues

from velocity.

nvb-uy avatar nvb-uy commented on June 10, 2024

a 1.5x limit would be nice, at least for my use case

from velocity.

nvb-uy avatar nvb-uy commented on June 10, 2024

do you know where I could modify this value? I can fork velocity in the meantime and test if it works with that change

from velocity.

electronicboy avatar electronicboy commented on June 10, 2024

oh, wait, run with -Dvelocity.increased-compression-cap=true, will set the cap to 128MB, I thought that would cause issues, but, I guess if it's just passthrough packets it shouldn't break much

from velocity.

nvb-uy avatar nvb-uy commented on June 10, 2024

I'll try that out in a bit and let you know, thanks

from velocity.

nvb-uy avatar nvb-uy commented on June 10, 2024

This is coming up now

[19:02:33 ERROR]: [server connection] newtykins -> lobby: exception encountered in com.velocitypowered.proxy.connection.backend.BackendPlaySessionHandler@3977ed98
io.netty.handler.codec.CorruptedFrameException: Error decoding class com.velocitypowered.proxy.protocol.packet.AvailableCommands Direction CLIENTBOUND Protocol 1.20 State PLAY ID 10

from velocity.

electronicboy avatar electronicboy commented on June 10, 2024

that is what cross stitch is generally for

from velocity.

nvb-uy avatar nvb-uy commented on June 10, 2024

Will try with that, I did notice though, it only seems to support up to 1.19.3?

from velocity.

nvb-uy avatar nvb-uy commented on June 10, 2024

That seems to have worked! Thanks a lot :)

from velocity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.