Code Monkey home page Code Monkey logo

Comments (10)

paoloricciuti avatar paoloricciuti commented on June 16, 2024

Make sense to me...I'll ship a fix tomorrow morning, thanks for reporting. 👍

from sveltekit-search-params.

paoloricciuti avatar paoloricciuti commented on June 16, 2024

This should be fixed in 1.0.7 let me know if that's ok and thanks again for reporting

from sveltekit-search-params.

devinellis avatar devinellis commented on June 16, 2024

@paoloricciuti Did you forget to create a release? Or are you still working on other changes to include in 1.0.7? Thanks

from sveltekit-search-params.

paoloricciuti avatar paoloricciuti commented on June 16, 2024

@paoloricciuti Did you forget to create a release? Or are you still working on other changes to include in 1.0.7? Thanks

Sorry I included changesets in the project so that I didn't need to create a release to publish on npm and I forgot to create the actual release announcement. However the package is updated on npm and you can already install it

https://www.npmjs.com/package/sveltekit-search-params

from sveltekit-search-params.

devinellis avatar devinellis commented on June 16, 2024

I updated my package.json and re-installed, and my app is still removing the url hash. I tried a default queryParam, and one set to pushHistory:false. Is there anything specific you'd like me to test?

from sveltekit-search-params.

paoloricciuti avatar paoloricciuti commented on June 16, 2024

uhm it's seems like it had some problem publishing and it published the old version with the new version number.

I will republish as soon as I can and hit you up here

from sveltekit-search-params.

paoloricciuti avatar paoloricciuti commented on June 16, 2024

@devinellis you can try with 1.0.9

from sveltekit-search-params.

devinellis avatar devinellis commented on June 16, 2024

I tried 1.0.9 and it's still getting stripped.

FWIW, before using SSP, I was calling history.pushState() and the hashtag was not stripped out. So I don't think its something else in my app causing the problem.

from sveltekit-search-params.

devinellis avatar devinellis commented on June 16, 2024

@paoloricciuti it works in 1.0.10! Thanks!

from sveltekit-search-params.

paoloricciuti avatar paoloricciuti commented on June 16, 2024

@paoloricciuti it works in 1.0.10! Thanks!

Well that's strange given I didn't change literally anything between 1.0.9 and 1.0.10 but I guess we don't care lol

from sveltekit-search-params.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.