Remove the field from the query parameters if it's null or undefined about sveltekit-search-params HOT 7 CLOSED

I'm not sure what the intention of this line is tbh, but if I remove the ! and an undefined param/val is encountered, then it's removed how i would expect it to be removed.

sveltekit-search-params/src/lib/sveltekit-search-params.ts

Line 172 in fcd9545

if (!(value as any)[field] == undefined) {

Yup looks like a bug...it was previously !value[field] and I added == undefined and probably forgot to remove the !

Thanks for reporting and also find the solution. If you want to make a PR to be credited as a contributor feel free to do it otherwise I'll go ahead and fix it in a while

from sveltekit-search-params.

Is this supposed to remove the parameter if the value of the parameter is null/undefined?

from sveltekit-search-params.

Is this supposed to remove the parameter if the value of the parameter is null/undefined?

It should but it also depends on other parts of the code...is this not happening?

from sveltekit-search-params.

(personal account)

In my case it is not. I'll see if I can make a minimal repro.

from sveltekit-search-params.

Here is a reproduction:

https://github.com/paoramati/sveltekit-search-params/tree/1_repro_undefined_not_deleting_query_params

Navigate to /params-issue

The error occurs when trying to update param values with null/undefined. Get this stacktrace (not sure if related yet).

Some context: In the application I'm building, there is a search box + certain pages have their own search boxes. I want to remove params created by the opposing search if a user uses the other kind of search.

I will have a look if I can create a fix, but I'm not sure whether it's just my usage is off, or if there is an issue with queryParams not getting removed from URL when they should be.

Thanks!

from sveltekit-search-params.

I'm not sure what the intention of this line is tbh, but if I remove the ! and an undefined param/val is encountered, then it's removed how i would expect it to be removed.

from sveltekit-search-params.

Cool, i'll make a PR tonight :)

from sveltekit-search-params.