Code Monkey home page Code Monkey logo

Comments (5)

panva avatar panva commented on May 18, 2024

What about having it on the returned tokenset?

from node-openid-client.

raijinsetsu avatar raijinsetsu commented on May 18, 2024

from node-openid-client.

panva avatar panva commented on May 18, 2024

Let me explain my thought process,

  • i don't want to provide a method to just decode a token, it should be only for the one's the library has validated
  • i want to avoid unnecessary double verification of tokens, as it can be, in some scenarios, quite an expensive operation
  • i don't want to extend the non-function properties on a tokenset

Making it a method on the tokenset makes sure no serialization that users already have in place will pick up an extra property. Putting it on a tokenset makes it immediately available after authorizationCallback and refresh calls, which is where you possibly want to read it anyway. Other than these cases, if you lose the tokenset entity itself, there's always base64decode ;)

from node-openid-client.

raijinsetsu avatar raijinsetsu commented on May 18, 2024

from node-openid-client.

panva avatar panva commented on May 18, 2024

See https://github.com/panva/node-openid-client/blob/master/CHANGELOG.md#version-120

from node-openid-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.