Code Monkey home page Code Monkey logo

Comments (6)

rhshadrach avatar rhshadrach commented on June 20, 2024

I believe this issue existed prior to the deprecation: it was never possible to just .fillna(value=None). And doing .fillna(value=None, method="ffill") would ignore the value parameter (since forward filling does not utilize a value). When the deprecation is enforced, we can make the value parameter required (instead of having a default), and then enable users to use .fillna(value=None).

from pandas.

rhshadrach avatar rhshadrach commented on June 20, 2024

Ref: #47639

from pandas.

Dr-Irv avatar Dr-Irv commented on June 20, 2024

I believe this issue existed prior to the deprecation: it was never possible to just .fillna(value=None). And doing .fillna(value=None, method="ffill") would ignore the value parameter (since forward filling does not utilize a value). When the deprecation is enforced, we can make the value parameter required (instead of having a default), and then enable users to use .fillna(value=None).

So should we update the docs now to reflect that Series.fillna(value=None) doesn't work? Because the way it reads now, it appears that it should work. I think that is what led to the confusion of the OP in pandas-dev/pandas-stubs#884

from pandas.

rhshadrach avatar rhshadrach commented on June 20, 2024

So should we update the docs now to reflect that Series.fillna(value=None) doesn't work?

I would vote no, but not opposed if someone wants to do that. This deficiency in the docs has existed for a long time, and I expect it to work come 3.0, so it doesn't seem worth the effort to change now.

from pandas.

phofl avatar phofl commented on June 20, 2024

agree with @rhshadrach

from pandas.

rhshadrach avatar rhshadrach commented on June 20, 2024

I have a PR in the works for enforcing said deprecation, I'll add a test for this and use that PR to close this issue.

from pandas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.