Code Monkey home page Code Monkey logo

Comments (3)

ndarilek avatar ndarilek commented on June 14, 2024

I can't seem to edit the issue title, but to be clear, I don't mean length divided by time, but the case of returning either a Length, Time, or some other typed value that I'm not mathematically combining with another. :) Thanks!

from dimensioned.

adeschamps avatar adeschamps commented on June 14, 2024

I made an attempt at this. I tried enabling impl Trait on nightly so I could return "something that implements Length", but I ran into a bit of trouble. If all you know is that something implements Length, there's not much you can do with it without knowing its concrete type - Length doesn't derive from Add, Mul, Sub, and so on.

Depending on the definition of Point, you could write a distance function using generics that declares all of the trait bounds it needs. It's a bit verbose though. I experimented with something similar a while ago, when I tried implementing a PID controller that was fully generic over its numeric types. The types end up being more complicated than the algebra.

use dimensioned::traits::*;
use std::ops::{Add, Mul, Sub};

struct Point<L>
    x: L,
    y: L,
}

fn distance<L, L2>(p1: &Point<L>, p2: &Point<L>) -> L
where
    L: Sub<Output = L> + Mul<Output = L2> + Copy,
    L2: Add<Output = L2> + Sqrt<Output = L> + Copy,
{
    let dx = p1.x - p2.x;
    let dy = p1.y - p2.y;
    (dx * dx + dy * dy).sqrt()
}

In my own code, I usually just pick a unit system and use its concrete types. So I have a lot of functions that return si::Meter<f64> and so on. If I need values in a different system, conversions are cheap and easy - the concrete types implement Into when appropriate.

from dimensioned.

jsbrucker avatar jsbrucker commented on June 14, 2024

@ndarilek I'm sure you've moved on from this issue at this point but for future users:

Here is a more concrete example* of what I suspect @adeschamps was suggesting at the end of his post above:

extern crate dimensioned as dim;
use dim::si::{Meter, MeterPerSecond, Second};

fn calc_velocity(distance: Meter<i64>, time: Second<i64>) -> MeterPerSecond<i64> {
    distance / time
}

Or if #74 is merged you could use:

extern crate dimensioned as dim;
use dim::si::dimensions::{Length, Time, Velocity};

fn calc_velocity(distance: Length<i64>, time: Time<i64>) -> Velocity<i64> {
    distance / time
}

Now in both cases the uses of i64 could be replaced by just about any concrete type(s) desired, or generics with trait bounds could be leveraged if appropriate.

*I recognize Length divided by Time types weren't actually needed in the OP but it makes for a more interesting example.
Edit: It also appears that basically the same example is already contained in the examples on the readme... I'm not sure how I missed that.

from dimensioned.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.