Inline occurence issue about js-assistant HOT 5 CLOSED

Thanks for the bug report! I'll update when I have a fix.

from js-assistant.

Hey @chandan192 - I agree that inlining here does not make sense, and you would typically not invoke it.

However, I'm not sure I understand what the issue with the refactoring is? The resulting code compiles and executes for me, and it indeed the expected result of an inline operation on temp3.

What would you expect to happen instead?

from js-assistant.

Hi @lgrammel,
I was just experimenting with the refactoring using p42 and tslint. I got the p42 refactoring suggestion on the context menu.
Inline 2 occurrences [p42]

I also checked the p42 suggestion on the activity bar but there was no suggestion. It was only on the manual context menu refactoring.

from js-assistant.

I see - in this case it was not a 'suggestion' (an in, P42 recommended), but it showed up in the quickfix menu. I'll add a warning similar to what is shown for new Objects.

from js-assistant.

I've made a couple of improvements in v1.103.1 to address this issue:

• inline variable warns you about inlining literals that are used in multiple places
• inline variable is only availalbe as a quickfix when it is a suggestion, otherwise you need to use the refactor or inline context menus / shortcuts

Thanks for the bug report!

from js-assistant.