Comments (11)
Thanks for the bug report!
Can you try the following example?
let a = "123";
f(a);
The 3 dots under let
are the suggestion indicator. Does it show for you?
Btw, in v1.86.0 the default suggestion level was changed from info
(blue squiggly underline) to hint
(3 dots) to make the suggestions look less distractive and indicate that they are not problems (many users perceived the squiggly line as such). You can set individual suggestions to different levels in the Visual Studio Code settings.
from js-assistant.
No joy :(
The red squiggle on f is just eslint complaining that f is not defined.
from js-assistant.
Do you have a p42.toml
in the root folder of your workspace? If so, please check if the refactoring is deactivated there (see https://p42.ai/documentation/p42-for-vscode/configuration#configuration-file for details, specific paths and/or refactorings could be disabled).
If not, can you set "p42.logging.error.enabled": true
in your VS Code settings, restart VS Code, open the file that should show suggestions, and then check if any errors are logged in the 'Output' panel (select P42)?
from js-assistant.
I don't have a p42.toml file so no worries there.
I added the setting (although vscode greys it out saying "Unknown Configuration Setting") and restarted vscode. There was nothing logged to the output panel.
The extension appears to be working because vscode shows that it had a 153ms activation time.
from js-assistant.
Thanks for checking! The "unknown configuration setting" is expected (the options are not exposed in the UI).
Just to make sure I'm not missing anything, what is the extension of the JavaScript file that you are working on?
P42 only works with certain extensions such as .js
, .ts
or .mjs
(see https://p42.ai/documentation/p42-for-vscode/faq for all extensions).
from js-assistant.
It is a .js file, but I think I've narrowed down the problem. It appears that the issue is related to multiple folders in the workspace. I created a test.js file with your code and saved it to a folder called p42-tests then ran the following tests:
Test 1
- Open folder with vscode
- P42 suggestions visible
- Save workspace
- Close and re-open workspace
- Suggestions still visible
Test 2
- Open folder with vscode
- P42 suggestions visible
- Add another folder to workspace
- Suggestions disappear
- Save workspace
- Close and reopen workspace
- Suggestions still not visible
from js-assistant.
Thanks for the investigation! I'll take a look at the multiple folders issue today and see if I can confirm & fix it.
from js-assistant.
Update: I have reproduced the issue, now working on a fix.
from js-assistant.
@pru-brennaveen I have just released version 1.86.1
, which adds support for multiple workspace folders. Please re-open this issue if you still encounter the bug in 1.86.1
or higher. Thanks again for the bug report!
from js-assistant.
Works! You are awesome, thanks for the super quick response and a great addon!
from js-assistant.
Thanks! I hope you find the extension helpful!
from js-assistant.
Related Issues (20)
- Let the user disable the custom keybindings in the extension config options HOT 5
- convert to const in for-of loops HOT 1
- Please return the "Move up/down" commands HOT 6
- Issue with convert-if-else-to-conditional-expression HOT 1
- Wrong code generated by "Convert if-else into conditional expression" using p42 VSCode plugin v1.163.1 HOT 1
- Cannot pass the payment process on the select country window HOT 3
- Remove unused imports/class methods/variables HOT 2
- Unsafe suggestions HOT 2
- Support for Svelte components HOT 1
- Insert console.log for variable HOT 2
- Command Palette integration HOT 2
- Convert to destructuring assignment
- Create new file when extract React component
- convert-function-to-object-method potentially unsafe
- p42.ai is down HOT 2
- Refactor Idea: extract functions inside functions
- is the site https://p42.ai/ down? HOT 1
- Make P42 settings apply to remote and workspace, honour jsconfig/tsconfig settings
- provide setting to set default suggestion level
- provide setting to disable the codeActionsOnSave HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from js-assistant.